Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934298AbdC3W0P (ORCPT ); Thu, 30 Mar 2017 18:26:15 -0400 Received: from server.atrad.com.au ([150.101.241.2]:58350 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932560AbdC3W0O (ORCPT ); Thu, 30 Mar 2017 18:26:14 -0400 Date: Fri, 31 Mar 2017 08:55:22 +1030 From: Jonathan Woithe To: Micha?? K??pie?? Cc: Darren Hart , Andy Shevchenko , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling Message-ID: <20170330222521.GC10297@marvin.atrad.com.au> References: <20170324104959.GA31520@marvin.atrad.com.au> <20170327235719.GE23486@marvin.atrad.com.au> <20170328061618.GA3694@ozzy.nask.waw.pl> <20170328230029.GA29146@marvin.atrad.com.au> <20170329071926.GA1070@ozzy.nask.waw.pl> <20170330033650.GF15472@localhost.localdomain> <20170330035626.GK19787@marvin.atrad.com.au> <20170330050430.GA3179@localhost.localdomain> <20170330064115.GA1068@ozzy.nask.waw.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170330064115.GA1068@ozzy.nask.waw.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMEDefang-action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 16 Hi Michael On Thu, Mar 30, 2017 at 08:41:15AM +0200, Micha?? K??pie?? wrote: > I noted your concerns about error handling in the driver ... For the time > being I would rather concentrate on the issues I personally consider more > pressing as I will most likely lose access to modern Fujitsu hardware in > about six weeks and I would really like to be able to test my patches on > hardware on which the code touched by these patches actually runs (LEDs > come to mind, specifically). I have no problem with this. Fixing consistency in connection with error handling is certainly something which can be done by me (or anyone else) at a later date. I agree that the other work is more important. Regards jonathan