Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbdCaEFf (ORCPT ); Fri, 31 Mar 2017 00:05:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47372 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751012AbdCaEFc (ORCPT ); Fri, 31 Mar 2017 00:05:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3CF2880469 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jasowang@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3CF2880469 Subject: Re: [PATCH 1/6] virtio: wrap find_vqs To: "Michael S. Tsirkin" References: <1490820507-8005-1-git-send-email-mst@redhat.com> <1490820507-8005-2-git-send-email-mst@redhat.com> <72f533a2-482d-1956-b0fe-254e273e1818@redhat.com> <20170330173146-mutt-send-email-mst@kernel.org> Cc: linux-kernel@vger.kernel.org, John Fastabend , Arnd Bergmann , Greg Kroah-Hartman , Amit Shah , Gonglei , Herbert Xu , "David S. Miller" , David Airlie , Gerd Hoffmann , Dmitry Tarnyagin , Ohad Ben-Cohen , Bjorn Andersson , "James E.J. Bottomley" , "Martin K. Petersen" , Stefan Hajnoczi , virtualization@lists.linux-foundation.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, kvm@vger.kernel.org From: Jason Wang Message-ID: Date: Fri, 31 Mar 2017 12:04:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170330173146-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 31 Mar 2017 04:05:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 793 Lines: 23 On 2017年03月30日 22:32, Michael S. Tsirkin wrote: > On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: >> >> On 2017年03月30日 04:48, Michael S. Tsirkin wrote: >>> We are going to add more parameters to find_vqs, let's wrap the call so >>> we don't need to tweak all drivers every time. >>> >>> Signed-off-by: Michael S. Tsirkin >>> --- >> A quick glance and it looks ok, but what the benefit of this series, is it >> required by other changes? >> >> Thanks > Yes - to avoid touching all devices when doing the rest of > the patchset. Maybe I'm not clear. I mean the benefit of this series not this single patch. I guess it may be used by you proposal that avoid reset when set XDP? If yes, do we really want to drop some packets after XDP is set? Thanks