Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754300AbdCaGs0 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 31 Mar 2017 02:48:26 -0400
Received: from mx2.suse.de ([195.135.220.15]:55945 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752541AbdCaGsZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 31 Mar 2017 02:48:25 -0400
Date: Fri, 31 Mar 2017 08:48:21 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-mm@kvack.org, "'Andrew Morton'" <akpm@linux-foundation.org>,
        "'Mel Gorman'" <mgorman@suse.de>, "'Vlastimil Babka'" <vbabka@suse.cz>,
        "'Andrea Arcangeli'" <aarcange@redhat.com>,
        "'Reza Arbab'" <arbab@linux.vnet.ibm.com>,
        "'Yasuaki Ishimatsu'" <yasu.isimatu@gmail.com>,
        "'Tang Chen'" <tangchen@cn.fujitsu.com>, qiuxishi@huawei.com,
        "'Kani Toshimitsu'" <toshi.kani@hpe.com>, slaoub@gmail.com,
        "'Joonsoo Kim'" <js1304@gmail.com>,
        "'Andi Kleen'" <ak@linux.intel.com>,
        "'Zhang Zhen'" <zhenzhang.zhang@huawei.com>,
        "'David Rientjes'" <rientjes@google.com>,
        "'Daniel Kiper'" <daniel.kiper@oracle.com>,
        "'Igor Mammedov'" <imammedo@redhat.com>,
        "'Vitaly Kuznetsov'" <vkuznets@redhat.com>,
        "'LKML'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] mm: get rid of zone_is_initialized
Message-ID: <20170331064821.GB27098@dhcp22.suse.cz>
References: <20170330115454.32154-1-mhocko@kernel.org>
 <20170330115454.32154-2-mhocko@kernel.org>
 <04a601d2a9d0$5ace0ab0$106a2010$@alibaba-inc.com>
 <20170331064301.GA27098@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170331064301.GA27098@dhcp22.suse.cz>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 725
Lines: 24

On Fri 31-03-17 08:43:01, Michal Hocko wrote:
> On Fri 31-03-17 11:39:07, Hillf Danton wrote:
> > 
> > On March 30, 2017 7:55 PM Michal Hocko wrote:
> > > 
> > > @@ -5535,9 +5535,6 @@ int __meminit init_currently_empty_zone(struct zone *zone,
> > >  			zone_start_pfn, (zone_start_pfn + size));
> > > 
> > >  	zone_init_free_lists(zone);
> > > -	zone->initialized = 1;
> > > -
> > > -	return 0;
> > >  }
> > Nit: Add changes more than correct.
> 
> I am sorry, I do not follow?

OK, got it. init_currently_empty_zone should be changed to void. Screw
up during the split of the initial patch. Will fix that up. Also
zone_spans_range should go to patch 5 because it doesn't have any user
until then.
-- 
Michal Hocko
SUSE Labs