Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754611AbdCaGtG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 31 Mar 2017 02:49:06 -0400
Received: from mx2.suse.de ([195.135.220.15]:56018 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752142AbdCaGtF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 31 Mar 2017 02:49:05 -0400
Date: Fri, 31 Mar 2017 08:49:01 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-mm@kvack.org, "'Andrew Morton'" <akpm@linux-foundation.org>,
        "'Mel Gorman'" <mgorman@suse.de>, "'Vlastimil Babka'" <vbabka@suse.cz>,
        "'Andrea Arcangeli'" <aarcange@redhat.com>,
        "'Reza Arbab'" <arbab@linux.vnet.ibm.com>,
        "'Yasuaki Ishimatsu'" <yasu.isimatu@gmail.com>,
        "'Tang Chen'" <tangchen@cn.fujitsu.com>, qiuxishi@huawei.com,
        "'Kani Toshimitsu'" <toshi.kani@hpe.com>, slaoub@gmail.com,
        "'Joonsoo Kim'" <js1304@gmail.com>,
        "'Andi Kleen'" <ak@linux.intel.com>,
        "'Zhang Zhen'" <zhenzhang.zhang@huawei.com>,
        "'David Rientjes'" <rientjes@google.com>,
        "'Daniel Kiper'" <daniel.kiper@oracle.com>,
        "'Igor Mammedov'" <imammedo@redhat.com>,
        "'Vitaly Kuznetsov'" <vkuznets@redhat.com>,
        "'LKML'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] mm: remove return value from
 init_currently_empty_zone
Message-ID: <20170331064901.GC27098@dhcp22.suse.cz>
References: <20170330115454.32154-1-mhocko@kernel.org>
 <20170330115454.32154-4-mhocko@kernel.org>
 <04ad01d2a9d1$d99b0540$8cd10fc0$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <04ad01d2a9d1$d99b0540$8cd10fc0$@alibaba-inc.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 710
Lines: 21

On Fri 31-03-17 11:49:49, Hillf Danton wrote:
[...]
> > -/* Can fail with -ENOMEM from allocating a wait table with vmalloc() or
> > - * alloc_bootmem_node_nopanic()/memblock_virt_alloc_node_nopanic() */
> > -static int __ref ensure_zone_is_initialized(struct zone *zone,
> > +static void __ref ensure_zone_is_initialized(struct zone *zone,
> >  			unsigned long start_pfn, unsigned long num_pages)
> >  {
> > -	if (zone_is_empty(zone))
> > -		return init_currently_empty_zone(zone, start_pfn, num_pages);
> > -
> > -	return 0;
> > +	if (!zone_is_empty(zone))
> > +		init_currently_empty_zone(zone, start_pfn, num_pages);
> >  }
> Semantic change added?

could you be more specific?
-- 
Michal Hocko
SUSE Labs