Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754450AbdCaHKL (ORCPT ); Fri, 31 Mar 2017 03:10:11 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:51200 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302AbdCaHKK (ORCPT ); Fri, 31 Mar 2017 03:10:10 -0400 Date: Fri, 31 Mar 2017 00:09:50 -0700 From: Christoph Hellwig To: Logan Gunthorpe Cc: Christoph Hellwig , Sagi Grimberg , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe , linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory. Message-ID: <20170331070950.GA9059@infradead.org> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-6-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490911959-5146-6-git-send-email-logang@deltatee.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 145 Lines: 3 You're calling memcpy_{to,from}_iomem on non-__iomem pointers. This is a fundamental no-go as we keep I/O memory separate from kernel pointers.