Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898AbdCaJ6u convert rfc822-to-8bit (ORCPT ); Fri, 31 Mar 2017 05:58:50 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:17076 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbdCaJ6s (ORCPT ); Fri, 31 Mar 2017 05:58:48 -0400 From: Salil Mehta To: David Miller CC: "Zhuangyuzeng (Yisen)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Subject: RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements Thread-Topic: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements Thread-Index: AQHSqWrTz6Jb6fg6m02zOKKzNlHCoaGuMxeAgABrapA= Date: Fri, 31 Mar 2017 09:58:24 +0000 Message-ID: References: <20170330153106.14344-1-salil.mehta@huawei.com> <20170330.200317.1176664200594872180.davem@davemloft.net> In-Reply-To: <20170330.200317.1176664200594872180.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.152] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.58DE2852.0040,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 4b3e9eb3fdb1e74820a24e4481e326e5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 38 > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Friday, March 31, 2017 4:03 AM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil.lnk@gmail.com; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code > Improvements > > From: Salil Mehta > Date: Thu, 30 Mar 2017 16:30:47 +0100 > > > This patch set introduces various HNS bug fixes, optimizations and > code > > improvements. > > There is no way you should do such an expensive calculation for every > single transmit packet as you are doing in your select_queue() routine. > > That's really crazy. > > Just use the networking stack's queue selection scheme, or suggest > ways to improve it. Don't do private hashing like this in your > driver, please! Hi David, I got your point. I will drop this patch from this patch-set for now. Thanks Salil