Subject: Re: [tip:WIP.x86/mm 1/1] arch/x86/kernel/process_64.c:541:35: error:
 '__NR_ia32_execve' undeclared
To: Thomas Gleixner <tglx@linutronix.de>
References: <201703301754.uKyz1CYf%fengguang.wu@intel.com>
 <e5b97751-bb8f-08d0-35c8-b7e1e9100b01@virtuozzo.com>
 <alpine.DEB.2.20.1703310901580.1780@nanos>
CC: kbuild test robot <fengguang.wu@intel.com>, <kbuild-all@01.org>,
        <linux-kernel@vger.kernel.org>, <tipbuild@zytor.com>
From: Dmitry Safonov <dsafonov@virtuozzo.com>
Message-ID: <48af146f-f3c3-d4fb-d306-8e9a10ef0016@virtuozzo.com>
Date: Fri, 31 Mar 2017 13:08:13 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1703310901580.1780@nanos>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2017 10:11:48.8655 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1739
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1096
Lines: 36

On 03/31/2017 10:25 AM, Thomas Gleixner wrote:
> On Thu, 30 Mar 2017, Dmitry Safonov wrote:
>>> vim +/__NR_ia32_execve +541 arch/x86/kernel/process_64.c
>>>
>>>    535		set_thread_flag(TIF_IA32);
>>>    536		clear_thread_flag(TIF_X32);
>>>    537		if (current->mm)
>>>    538			current->mm->context.ia32_compat = TIF_IA32;
>>>    539		current->personality |= force_personality32;
>>>    540		/* Prepare the first "return" to user space */
>>>  > 541		task_pt_regs(current)->orig_ax = __NR_ia32_execve;
>>>    542		current->thread.status |= TS_COMPAT;
>>>    543	#endif
>>>    544	}
>>
>> There was this chunk in the patch, maybe it could be done nicer,
>> but I didn't find the nicer way.
>> I checked it compilation/work with(out) ia32/x32/64-bit configs
>> before sending.
>
> Yeah, I know and it's just crap. WTF is wrong with:

Oh, here it is the nicer way.
I've forgot that `git grep` doesn't look into generated files.

> #ifdef CONFIG_IA32_EMULATION
> #include <asm/unistd_32_ia32.h>
> #endif
>
> It's not rocket science, really.

Sorry about that, I'll resend.


-- 
              Dmitry