Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932908AbdCaKVU (ORCPT ); Fri, 31 Mar 2017 06:21:20 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41130 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbdCaKVS (ORCPT ); Fri, 31 Mar 2017 06:21:18 -0400 X-ME-Sender: X-Sasl-enc: M843+X8l15347ys8pJpPHNEnr80MAS1H4GgGFk/Cw5Jf 1490955676 Date: Fri, 31 Mar 2017 21:21:13 +1100 From: "Tobin C. Harding" To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , devel@linuxdriverproject.org, Tycho Andersen Subject: Re: [PATCH RFC] remove custom Michael MIC implementation Message-ID: <20170331102113.GA2930@eros> References: <1490935659-7196-1-git-send-email-me@tobin.cc> <20170331075851.GB1435@katana> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <20170331075851.GB1435@katana> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2819 Lines: 75 --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: >=20 > > The code is untested, I have hardware in the mail. >=20 > Cool! The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is a SDW-823 and should use the ks7010 driver. I am going to attempt to get it running on a Raspberry Pi B+. I ordered the wrong size break out board originally so waiting on the new one now. >=20 > > If any one is interested and has any comments I would really like to > > hear them. I am open to all suggestions (even down to trivial coding > > style issues). >=20 > I'll just repeat that the key move to get this driver out of staging is > to get away from the WEXT interface to CFG80211. Otherwise no chance > that wireless maintainers will even look at it. This is a huge change > but once it is done, features like Michael MIC come with it for free > (from what I recall, I am not a wireless expert myself). That would explain why I could not find more than the Orinoco driver using the Michael MIC module directly. > Without the CFG80211 conversion, replacing the Michael custom > implementation with the in-kernel one makes the driver a tad better and > is good exercise. However, it will sadly not help to get the driver out > of staging. I'll drop it then. Could you please tell me, is there any thing else more I need to do to let LKML know that this RFC is dropped? Or is this reply enough. I don't want to use any ones time unnecessarily. >=20 > But if you want a clean WEXT driver first, this is a step in the right > direction. >=20 Let's go for a CFG80211 driver and get out of staging :) So next step is I guess study the ath6kl driver, learn how CFG80211 is done and implement that interface in ks7010? Oh, and test that it works. thanks, Tobin. --envbJBWh7q8WU6mo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJY3i2RAAoJEEC/nkwmnWYH/WsQAIx7bUisjm8UcxSkx9UYn7O3 iIMAWWKsgAL8kwQKyofbNPpL6nZUZ0YrEvENAb7KCveS2YKm8fmZSk8vAR77Zd4y yyCALilVw5JQLKPtCi44BWFmlswqJ8erXw6pUSAerG1GpvwmUxm73HYTK4FlJg4F lq0BSEvfSSdDmeMzxckTp1YZauCInvNW4e4oevOiy4iahRhd9/+SxXeDWJBTDZ7r 3InN3mphYtjZBcEbhMRIWMJoI4mCg+M1KMWsSL+vvSgXy/gICmgS6FnCOs0XCmQD fkJYzm9DXyugDLVGMmOyAJJTvwwu8BAp9edb398B0PV/9mlWSRZb/ZMTA4VsJpS8 eAMK0YifFSlH3Rp/mXcVP7O38KPali9EYEhaUSRKvVA7xgFQucj0Iv092H3tVjLl +VP+cdNqrXVQQu3dSMXn+s1XCIwec8lVg/IPx3i/FXrdqm2a6DA8by3Z6PlNQqme wlAe/WPqo7tcnehpI3WF1tAwkqeOAkg/gc0ynl0hWVt6Rn4xh2QsGax5nNDR7t+z A9nYTkbueN5rcUGJKCeAbz6TLg8XoYwWriQwNqAZSl2Fsv+eEbaw7kEJBSs4mDaY OIBTAKCaad7Vg+2JlkTL6fMQ80QS3vrLQoWl/Lsxy61wHhzFXPXCkmD8gPV4NCvX iXGm40jzEeu36qwF96sj =LDEx -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--