Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933033AbdCaK2i (ORCPT ); Fri, 31 Mar 2017 06:28:38 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:19274 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932817AbdCaK2h (ORCPT ); Fri, 31 Mar 2017 06:28:37 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 31 Mar 2017 03:28:35 -0700 Subject: Re: [PATCH] serial: tegra: Map the iir register to default defines To: Shardar Mohammed , Laxman Dewangan , Olliver Schinagl , "Greg Kroah-Hartman" , Jiri Slaby , Stephen Warren , Thierry Reding , Alexandre Courbot References: <20170329184806.6577-1-oliver@schinagl.nl> <58DCDB54.5040005@nvidia.com> <83c51151685d4be7926f7f3982c59db8@bgmail102.nvidia.com> CC: "linux-serial@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jon Hunter Message-ID: Date: Fri, 31 Mar 2017 11:28:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <83c51151685d4be7926f7f3982c59db8@bgmail102.nvidia.com> X-Originating-IP: [10.21.132.162] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 44 On 31/03/17 11:07, Shardar Mohammed wrote: > Verification failed on Tegra. > Fix here is, IIR should be masked with UART_IIR_MASK after reading the IIR register as on Tegra bit-6 is used for internal usage to know if FIFO mode is enabled. > while (1) { > iir = tegra_uart_read(tup, UART_IIR); > +iir &= UART_IIR_MASK; Per Olliver's original email did you pick up the other patch [0] before applying this because that does apply the mask. I mentioned to Olliver that this should really be a series, so it is clear that this patch is dependent upon the other. > -----Original Message----- > From: Laxman Dewangan > Sent: Thursday, March 30, 2017 3:48 PM > To: Olliver Schinagl ; Greg Kroah-Hartman ; Jiri Slaby ; Stephen Warren ; Thierry Reding ; Alexandre Courbot > Cc: linux-serial@vger.kernel.org; linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org; Shardar Mohammed > Subject: Re: [PATCH] serial: tegra: Map the iir register to default defines > > > On Thursday 30 March 2017 12:18 AM, Olliver Schinagl wrote: >> The tegra serial IP seems to be following the common layout and the >> interrupt ID's match up nicely. Replace the magic values to match the >> common serial_reg defines, with the addition of the Tegra unique End >> of Data interrupt. >> >> Signed-off-by: Olliver Schinagl >> --- > > Adding Shardar for verifications. > > Acked-by: Laxman Dewangan Furthermore does this ACK imply that you have reviewed the other patch this one is dependent upon? Cheers Jon [0] http://marc.info/?l=linux-serial&m=149081309627392&w=2 -- nvpublic