Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933063AbdCaK3Y (ORCPT ); Fri, 31 Mar 2017 06:29:24 -0400 Received: from mga11.intel.com ([192.55.52.93]:52236 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932781AbdCaK3X (ORCPT ); Fri, 31 Mar 2017 06:29:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,251,1486454400"; d="scan'208";a="840364325" From: Jani Nikula To: Zhenyu Wang , Jiri Slaby Cc: linux-kernel@vger.kernel.org, Martin Liska , Zhi Wang , Daniel Vetter , David Airlie , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Arnd Bergmann Subject: Re: [PATCH] drm/i915: disable KASAN for handlers In-Reply-To: <20170331072148.lbb7x6tj5egkpppm@zhen-hp.sh.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170330094627.29460-1-jslaby@suse.cz> <20170331072148.lbb7x6tj5egkpppm@zhen-hp.sh.intel.com> Date: Fri, 31 Mar 2017 13:29:18 +0300 Message-ID: <87mvc13fk1.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2260 Lines: 58 On Fri, 31 Mar 2017, Zhenyu Wang wrote: > On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >> Handlers are currently the only blocker to compile the kernel with gcc 7 >> and KASAN+use-after-scope enabled: >> drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> >> It is due to many expansions of MMIO_* macros in init_generic_mmio_info. >> INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an >> offset. There are too many for KASAN to keep up. >> >> So disable KASAN for this file. >> >> Signed-off-by: Jiri Slaby >> Cc: Martin Liska >> Cc: Zhenyu Wang >> Cc: Zhi Wang >> Cc: Daniel Vetter >> Cc: Jani Nikula >> Cc: David Airlie >> Cc: intel-gvt-dev@lists.freedesktop.org >> Cc: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org >> --- >> drivers/gpu/drm/i915/gvt/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile >> index b123c20e2097..942f1849d194 100644 >> --- a/drivers/gpu/drm/i915/gvt/Makefile >> +++ b/drivers/gpu/drm/i915/gvt/Makefile >> @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ >> ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall >> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) >> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o >> + >> +KASAN_SANITIZE_handlers.o := n >> -- >> 2.12.2 >> > > Applied this, we'd better cleanup legacy usage to current i915 mmio > reg define. Thanks! Hmmh, that was a bit fast, there was a related discussion going in [1]. BR, Jani. [1] http://mid.mail-archive.com/20170320215713.3086140-1-arnd@arndb.de -- Jani Nikula, Intel Open Source Technology Center