Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932999AbdCaKmV convert rfc822-to-8bit (ORCPT ); Fri, 31 Mar 2017 06:42:21 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:1587 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932619AbdCaKmT (ORCPT ); Fri, 31 Mar 2017 06:42:19 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 31 Mar 2017 03:38:57 -0700 From: Shardar Mohammed To: Jonathan Hunter , Laxman Dewangan , Olliver Schinagl , "Greg Kroah-Hartman" , Jiri Slaby , Stephen Warren , Thierry Reding , Alexandre Courbot CC: "linux-serial@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] serial: tegra: Map the iir register to default defines Thread-Topic: [PATCH] serial: tegra: Map the iir register to default defines Thread-Index: AQHSqUFsoB73X/6LZU+DGr0lGyKvNKGuuJrggAAH9wCAAAGX8A== Date: Fri, 31 Mar 2017 10:42:11 +0000 Message-ID: <79efc1286adc4119be65e0b237aebbc3@bgmail102.nvidia.com> References: <20170329184806.6577-1-oliver@schinagl.nl> <58DCDB54.5040005@nvidia.com> <83c51151685d4be7926f7f3982c59db8@bgmail102.nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.19.65.62] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2122 Lines: 56 > On 31/03/17 11:07, Shardar Mohammed wrote: > > Verification failed on Tegra. > > Fix here is, IIR should be masked with UART_IIR_MASK after reading the IIR > register as on Tegra bit-6 is used for internal usage to know if FIFO mode is > enabled. > > while (1) { > > iir = tegra_uart_read(tup, UART_IIR); > > +iir &= UART_IIR_MASK; > > Per Olliver's original email did you pick up the other patch [0] before applying > this because that does apply the mask. I mentioned to Olliver that this should > really be a series, so it is clear that this patch is dependent upon the other. For UART_IIR_MASK macro, dependent patch is required if we add this required line. But here to fix the issue with the current patch above masking step is necessary. > > > -----Original Message----- > > From: Laxman Dewangan > > Sent: Thursday, March 30, 2017 3:48 PM > > To: Olliver Schinagl ; Greg Kroah-Hartman > > ; Jiri Slaby ; Stephen > > Warren ; Thierry Reding > > ; Alexandre Courbot > > Cc: linux-serial@vger.kernel.org; linux-tegra@vger.kernel.org; > > linux-kernel@vger.kernel.org; Shardar Mohammed > > > Subject: Re: [PATCH] serial: tegra: Map the iir register to default > > defines > > > > > > On Thursday 30 March 2017 12:18 AM, Olliver Schinagl wrote: > >> The tegra serial IP seems to be following the common layout and the > >> interrupt ID's match up nicely. Replace the magic values to match the > >> common serial_reg defines, with the addition of the Tegra unique End > >> of Data interrupt. > >> > >> Signed-off-by: Olliver Schinagl > >> --- > > > > Adding Shardar for verifications. > > > > Acked-by: Laxman Dewangan > > Furthermore does this ACK imply that you have reviewed the other patch this > one is dependent upon? > Yes dependent change looks fine, but I have not tested it. > Cheers > Jon > > [0] http://marc.info/?l=linux-serial&m=149081309627392&w=2 > > -- > nvpublic