Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754666AbdCaLT7 (ORCPT ); Fri, 31 Mar 2017 07:19:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:57305 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932709AbdCaLTy (ORCPT ); Fri, 31 Mar 2017 07:19:54 -0400 From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, Juergen Gross Subject: [PATCH 2/2] xen: make functions in xen-acpi-processor return void Date: Fri, 31 Mar 2017 13:19:48 +0200 Message-Id: <20170331111948.17539-3-jgross@suse.com> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170331111948.17539-1-jgross@suse.com> References: <20170331111948.17539-1-jgross@suse.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2162 Lines: 60 The return value of xen_copy_pct_data() is always 0 and never checked. xen_copy_psd_data() returns always 0, too, so checking the value is kind of pointless. Make the functions return void. Signed-off-by: Juergen Gross --- drivers/xen/xen-acpi-processor.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c index 3659ed3..8f01585 100644 --- a/drivers/xen/xen-acpi-processor.c +++ b/drivers/xen/xen-acpi-processor.c @@ -161,8 +161,8 @@ xen_copy_pss_data(struct acpi_processor *_pr, } return dst_states; } -static int xen_copy_psd_data(struct acpi_processor *_pr, - struct xen_processor_performance *dst) +static void xen_copy_psd_data(struct acpi_processor *_pr, + struct xen_processor_performance *dst) { struct acpi_psd_package *pdomain; @@ -189,10 +189,9 @@ static int xen_copy_psd_data(struct acpi_processor *_pr, } memcpy(&(dst->domain_info), pdomain, sizeof(struct acpi_psd_package)); - return 0; } -static int xen_copy_pct_data(struct acpi_pct_register *pct, - struct xen_pct_register *dst_pct) +static void xen_copy_pct_data(struct acpi_pct_register *pct, + struct xen_pct_register *dst_pct) { /* It would be nice if you could just do 'memcpy(pct, dst_pct') but * sadly the Xen structure did not have the proper padding so the @@ -205,7 +204,6 @@ static int xen_copy_pct_data(struct acpi_pct_register *pct, dst_pct->bit_offset = pct->bit_offset; dst_pct->reserved = pct->reserved; dst_pct->address = pct->address; - return 0; } static int push_pxx_to_hypervisor(struct acpi_processor *_pr) { @@ -233,8 +231,8 @@ static int push_pxx_to_hypervisor(struct acpi_processor *_pr) set_xen_guest_handle(dst_perf->states, dst_states); dst_perf->flags |= XEN_PX_PSS; } - if (!xen_copy_psd_data(_pr, dst_perf)) - dst_perf->flags |= XEN_PX_PSD; + xen_copy_psd_data(_pr, dst_perf); + dst_perf->flags |= XEN_PX_PSD; if (dst_perf->flags != (XEN_PX_PSD | XEN_PX_PSS | XEN_PX_PCT | XEN_PX_PPC)) { pr_warn("ACPI CPU%u missing some P-state data (%x), skipping\n", -- 2.10.2