Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933180AbdCaL2P (ORCPT ); Fri, 31 Mar 2017 07:28:15 -0400 Received: from mail-wr0-f180.google.com ([209.85.128.180]:34251 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933038AbdCaL2K (ORCPT ); Fri, 31 Mar 2017 07:28:10 -0400 From: Olliver Schinagl X-Google-Original-From: Olliver Schinagl Subject: Re: [PATCH] serial: Do not treat the IIR register as a bitfield To: "Theodore Ts'o" , Vignesh R , Greg Kroah-Hartman , Jiri Slaby , Laxman Dewangan , Stephen Warren , Thierry Reding , Alexandre Courbot , "David S . Miller" , "dev@linux-sunxi.org" , Ed Blake , Andy Shevchenko , Alexander Sverdlin , Yegor Yefremov , Wan Ahmad Zainie , Kefeng Wang , Heikki Krogerus , Heiko Stuebner , Jason Uy , Douglas Anderson , Peter Hurley , Tony Lindgren , Thor Thayer , David Lechner , Jan Kiszka , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "sparclinux@vger.kernel.org" References: <20170329184431.6226-1-oliver@schinagl.nl> <6be65e8b-eea4-08ed-0b30-5c0608764a83@ti.com> <20170330141153.mvxa6iqj72hnhlu3@thunk.org> Message-ID: <03bb0be7-3534-0f26-9f79-061282331186@schinagl.nl> Date: Fri, 31 Mar 2017 13:28:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170330141153.mvxa6iqj72hnhlu3@thunk.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2043 Lines: 61 Hey Ted, On 30-03-17 16:11, Theodore Ts'o wrote: > While you're fixing this, there's a bug in samples/vfio-mdev/mtty.c: > > u8 ier = mdev_state->s[index].uart_reg[UART_IER]; > *buf = 0; > > mutex_lock(&mdev_state->rxtx_lock); > /* Interrupt priority 1: Parity, overrun, framing or break */ > if ((ier & UART_IER_RLSI) && mdev_state->s[index].overrun) > *buf |= UART_IIR_RLSI; > > /* Interrupt priority 2: Fifo trigger level reached */ > if ((ier & UART_IER_RDI) && > (mdev_state->s[index].rxtx.count == > mdev_state->s[index].intr_trigger_level)) > *buf |= UART_IIR_RDI; > > /* Interrupt priotiry 3: transmitter holding register empty */ > if ((ier & UART_IER_THRI) && > (mdev_state->s[index].rxtx.head == > mdev_state->s[index].rxtx.tail)) > *buf |= UART_IIR_THRI; > > /* Interrupt priotiry 4: Modem status: CTS, DSR, RI or DCD */ > if ((ier & UART_IER_MSI) && > (mdev_state->s[index].uart_reg[UART_MCR] & > (UART_MCR_RTS | UART_MCR_DTR))) > *buf |= UART_IIR_MSI; > > /* bit0: 0=> interrupt pending, 1=> no interrupt is pending */ > if (*buf == 0) > *buf = UART_IIR_NO_INT; > > It's treating the UART_IIR_* fields as a bitmask which is bad enough, > but in the "Interrupt priority 4" case, UART_IIR_MSI is zero, so > "*buf |= UART_IIR_MSI" is a no-op. And in the case where the modem > status interrupt is the only thing set, *buf will be 0, and UART_IIR_NO_INT > gets set erroneously. > > So this is another example of the bug of trying to treat the > UART_IIR_* fields as a bitmask.... > > Yes, it's only sample code, but best fix it now before it gets copied > elsewhere and metastisizes. :-) Yeah, I notice that a lot of the code I modified in this patch was either copy pasted or 'inspired by'. So having bad examples around is really bad as you state! Additionally the friendly build bot reminded me there are other subsystems that do this as well, so I'll update the patch to get those too and this one too. Olliver > > - Ted > >