Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933197AbdCaMOW (ORCPT ); Fri, 31 Mar 2017 08:14:22 -0400 Received: from mga14.intel.com ([192.55.52.115]:30466 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932858AbdCaMOU (ORCPT ); Fri, 31 Mar 2017 08:14:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,251,1486454400"; d="scan'208";a="67355288" Subject: Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI To: Andy Shevchenko , Tan Chin Yew , Wolfram Sang , Mika Westerberg References: <1490690882-11623-1-git-send-email-chin.yew.tan@intel.com> <1490690882-11623-2-git-send-email-chin.yew.tan@intel.com> <1490692426.708.26.camel@linux.intel.com> Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org From: Jarkko Nikula Message-ID: <237c2cf5-17dd-3d9c-ed4e-d0eadf611dfc@linux.intel.com> Date: Fri, 31 Mar 2017 15:12:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490692426.708.26.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 15 On 03/28/2017 12:13 PM, Andy Shevchenko wrote: > On Tue, 2017-03-28 at 16:48 +0800, Tan Chin Yew wrote: >> Sda-hold-time is an important parameter for tuning i2c to meet the >> electrical specification especially for high speed. I2C with incorrect >> sda-hold-time may cause lost arbitration error. Instead of loading all >> speed mode settings, only selected speed mode settings are loaded. >> >> Signed-off-by: Tan Chin Yew > > > Looks good to me: > > Reviewed-by: Andy Shevchenko > Acked-by: Jarkko Nikula