Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264859AbTE1USQ (ORCPT ); Wed, 28 May 2003 16:18:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264860AbTE1USQ (ORCPT ); Wed, 28 May 2003 16:18:16 -0400 Received: from elaine24.Stanford.EDU ([171.64.15.99]:27608 "EHLO elaine24.Stanford.EDU") by vger.kernel.org with ESMTP id S264859AbTE1USP (ORCPT ); Wed, 28 May 2003 16:18:15 -0400 Date: Wed, 28 May 2003 13:31:29 -0700 (PDT) From: Junfeng Yang To: Hollis Blanchard cc: linux-kernel@vger.kernel.org Subject: Re: [CHECKER][PATCH] cmpci user-pointer fix In-Reply-To: <5C5CFB74-9149-11D7-8297-000A95A0560C@us.ibm.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 29 > --------------------------------------------------------- > > I believe the attached patch fixes it. cm_write was calling access_ok, > but after that you must still access user space through the > get/put/copy*_user functions. It should be safe to return -EFAULT at > these points in cm_write, since there are other returns already in the > code above and below that. Compile-tested only. Thanks a lot for the fixes! > > Junfeng, the checker seems to have missed the "*dst0++ = *src++;" bits > at the bottom of the patch... or at least it wasn't in the mail I saw > ("4 potential user-pointer errors", 2 May 2003). I deliberately surpressed 'redudant' error reports. When the checker saw multiple errors caused by the same user pointer in one function, it'll only report one error for this user pointer in this function. if I don't do so, people tend to get bored by the 'repeated' messages, and leave error reports in other functions uninspected. ;) I'll re-run the checker soon with the suppression off. -Junfeng - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/