Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933305AbdCaMq5 (ORCPT ); Fri, 31 Mar 2017 08:46:57 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:43296 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933282AbdCaMqb (ORCPT ); Fri, 31 Mar 2017 08:46:31 -0400 Date: Fri, 31 Mar 2017 14:46:24 +0200 From: Ralf Baechle To: Matt Redfearn Cc: James Hogan , linux-mips@linux-mips.org, Marc Zyngier , Jason Cooper , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip/mips-gic: Fix Local compare interrupt Message-ID: <20170331124624.GA26330@linux-mips.org> References: <1490958332-31094-1-git-send-email-matt.redfearn@imgtec.com> <1490958332-31094-3-git-send-email-matt.redfearn@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490958332-31094-3-git-send-email-matt.redfearn@imgtec.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 27 On Fri, Mar 31, 2017 at 12:05:32PM +0100, Matt Redfearn wrote: > Commit 4cfffcfa5106 ("irqchip/mips-gic: Fix local interrupts") added > mapping of several local interrupts during initialisation of the gic > driver. This associates virq numbers with these interrupts. > Unfortunately, as not all of the interrupts are mapped in hardware > order, when drivers subsequently request these interrupts they conflict > with the mappings that have already been set up. For example, this > manifests itself in the gic clocksource driver, which fails to probe > with the message: > > clocksource: GIC: mask: 0xffffffffffffffff max_cycles: 0x7350c9738, > max_idle_ns: 440795203769 ns > GIC timer IRQ 25 setup failed: -22 > > This is because virq 25 (the correct IRQ number specified via device > tree) was allocated to the PERFCTR interrupt (and 24 to the timer, 26 to > the FDC). To fix this, map all of these local interrupts in the hardware > order so as to associate their virq numbers with the correct hw > interrupts. > > Fixes: 4cfffcfa5106 ("irqchip/mips-gic: Fix local interrupts") > Signed-off-by: Matt Redfearn Acked-by: Ralf Baechle Ralf