Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933467AbdCaMxZ (ORCPT ); Fri, 31 Mar 2017 08:53:25 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:15187 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933286AbdCaMxX (ORCPT ); Fri, 31 Mar 2017 08:53:23 -0400 Subject: Re: [PATCH 1/2] MIPS: Malta: Fix i8259 irqchip setup To: Ralf Baechle References: <1490958332-31094-1-git-send-email-matt.redfearn@imgtec.com> <1490958332-31094-2-git-send-email-matt.redfearn@imgtec.com> <20170331124916.GB26330@linux-mips.org> CC: James Hogan , , , Paul Burton From: Matt Redfearn Message-ID: <52fea079-fb63-6619-8115-2dbfc5ab022b@imgtec.com> Date: Fri, 31 Mar 2017 13:53:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170331124916.GB26330@linux-mips.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.150.130.83] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 39 Hi Ralf, On 31/03/17 13:49, Ralf Baechle wrote: > On Fri, Mar 31, 2017 at 12:05:31PM +0100, Matt Redfearn wrote: > >> diff --git a/arch/mips/mti-malta/malta-int.c b/arch/mips/mti-malta/malta-int.c >> index cb675ec6f283..474b372e0dd9 100644 >> --- a/arch/mips/mti-malta/malta-int.c >> +++ b/arch/mips/mti-malta/malta-int.c >> @@ -232,6 +232,19 @@ void __init arch_init_irq(void) >> { >> int corehi_irq; >> >> +#ifdef CONFIG_I8259 >> + /* >> + * Preallocate the i8259's expected virq's here. Since irqchip_init() >> + * will probe the irqchips in hierarchial order, i8259 is probed last. >> + * If anything allocates a virq before the i8259 is probed, it will >> + * be given one of the i8259's expected range and consequently setup >> + * of the i8259 will fail. >> + */ >> + WARN(irq_alloc_descs(I8259A_IRQ_BASE, I8259A_IRQ_BASE, >> + 16, numa_node_id()) < 0, >> + "Cannot reserve i8259 virqs at IRQ%d\n", I8259A_IRQ_BASE); >> +#endif /* CONFIG_I8259 */ >> + >> i8259_set_poll(mips_pcibios_iack); > CONFIG_I8259 is always defined on Malta so the #ifdef is pointless. > > Ralf Ah, true. I was looking at arch/mips/include/asm/mach-generic/irq.h where I8259A_IRQ_BASE is defined, it's wrapped in that CONFIG so I kept it here, but you're right of course that Malta always defines it. Would you like a v2 with that removed? Thanks, Matt