Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933343AbdCaNOm (ORCPT ); Fri, 31 Mar 2017 09:14:42 -0400 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:36433 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932927AbdCaNOj (ORCPT ); Fri, 31 Mar 2017 09:14:39 -0400 Subject: Re: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats To: Neil Armstrong , dri-devel@lists.freedesktop.org, laurent.pinchart+renesas@ideasonboard.com, architt@codeaurora.org, mchehab@kernel.org References: <1490864675-17336-1-git-send-email-narmstrong@baylibre.com> <1490864675-17336-4-git-send-email-narmstrong@baylibre.com> Cc: Jose.Abreu@synopsys.com, kieran.bingham@ideasonboard.com, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-media@vger.kernel.org, hans.verkuil@cisco.com, sakari.ailus@linux.intel.com From: Hans Verkuil Message-ID: <75ede5b8-ad35-c23f-2f02-c206df379357@xs4all.nl> Date: Fri, 31 Mar 2017 15:14:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1490864675-17336-4-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 31 On 30/03/17 11:04, Neil Armstrong wrote: > Add documentation for added Bus Formats to describe RGB and YUV formats used > as input to the Synopsys DesignWare HDMI TX Controller. > > Signed-off-by: Neil Armstrong > --- > Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++++++++++++++++++++++- > 1 file changed, 857 insertions(+), 14 deletions(-) This looks good, but the "Packed YUV Formats" documentation should be updated. Currently this says: - The number of bus samples per pixel. Pixels that are wider than the bus width must be transferred in multiple samples. Common values are 1, 1.5 (encoded as 1_5) and 2. I propose this change: - The number of bus samples per pixel. Pixels that are wider than the bus width must be transferred in multiple samples. Common values are 0.5 (encoded as 0_5; in this case two pixels are transferred per bus sample), 1, 1.5 (encoded as 1_5) and 2. With that additional change you can add my: Acked-by: Hans Verkuil Regards, Hans