From: "Riley Williams" <Riley@Williams.Name>
To: "Andrew Morton" <akpm@digeo.com>, "Pavel Machek" <pavel@ucw.cz>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: 2.5.70: CODA breaks boot
Date: Wed, 28 May 2003 22:00:06 +0100
Message-ID: <BKEGKPICNAKILKJKMHCACEPLEBAA.Riley@Williams.Name>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
In-Reply-To: <20030528043600.650a2f82.akpm@digeo.com>
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1569
Lines: 44

Hi Andrew.

 >> ...it oopses in kmem_cache_create, called from release_console_sem and
 >>  coda_init_inodecache.

 > You'll be needing this one.
 > 
 >  fs/coda/inode.c |    6 +++---
 >  1 files changed, 3 insertions(+), 3 deletions(-)
 > 
 > diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c
 > --- 25/fs/coda/inode.c~coda-typo-fix	2003-05-27 22:27:11.000000000 -0700
 > +++ 25-akpm/fs/coda/inode.c	2003-05-27 22:27:27.000000000 -0700
 > @@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c
 >  int coda_init_inodecache(void)
 >  {
 >  	coda_inode_cachep = kmem_cache_create("coda_inode_cache",
 > -					     sizeof(struct coda_inode_info),
 > +				sizeof(struct coda_inode_info),
 > -					     0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT,
 > +				0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
 > -					     init_once, NULL);
 > +				init_once, NULL);
 >  	if (coda_inode_cachep == NULL)
 >  		return -ENOMEM;
 >  	return 0;

That patch has me puzzled. Other than changing the white space, what actual
change to the code does it make? I can't see any.

Best wishes from Riley.
---
 * Nothing as pretty as a smile, nothing as ugly as a frown.

---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.484 / Virus Database: 282 - Release Date: 27-May-2003

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/