Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754963AbdCaNhh (ORCPT ); Fri, 31 Mar 2017 09:37:37 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:32837 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661AbdCaNhf (ORCPT ); Fri, 31 Mar 2017 09:37:35 -0400 MIME-Version: 1.0 In-Reply-To: <871stqc1ps.fsf@intel.com> References: <20170320215713.3086140-1-arnd@arndb.de> <877f3javde.fsf@intel.com> <20170321103302.fnrt4tnze46grmdi@phenom.ffwll.local> <871stqc1ps.fsf@intel.com> From: Arnd Bergmann Date: Fri, 31 Mar 2017 15:37:33 +0200 X-Google-Sender-Auth: y0zoC4NUh1--si5kJ4aII22SMbo Message-ID: Subject: Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro To: Jani Nikula Cc: Daniel Vetter , Ander Conselvan de Oliveira , David Airlie , Linux Kernel Mailing List , dri-devel , Daniel Vetter , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1256 Lines: 29 On Tue, Mar 21, 2017 at 12:23 PM, Jani Nikula wrote: > On Tue, 21 Mar 2017, Daniel Vetter wrote: >> On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: > Arnd, can you check that with kasan please? (I don't have gcc 7.) For me > the size diff against current git is > > text data bss dec hex filename > -1137236 31211 2948 1171395 11dfc3 drivers/gpu/drm/i915/i915.ko > +1139702 31211 2948 1173861 11e965 drivers/gpu/drm/i915/i915.ko Sorry for the late reply. I was rather sure that I had done the numbers and replied to you earlier, but I see no evidence of that, so here it comes again, using gcc-7 and kasan: text data bss dec hex filename 2623339 511153 12064 3146556 30033c obj-x86/drivers/gpu/drm/i915/i915-original.o 2634886 511153 12064 3158103 303057 obj-x86/drivers/gpu/drm/i915/i915-linux-next.o 2617989 520561 12064 3150614 301316 obj-x86/drivers/gpu/drm/i915/i915-arndpatch.o The first one is linux-next with ce64645d86ac ("drm/i915: use variadic macros and arrays to choose port/pipe based registers") reverted, the second one is the current version, and the third is with my patch applied on top. Arnd