DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B6189C05B1C8
Date: Fri, 31 Mar 2017 15:39:23 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lei.cao@stratus.com
Subject: Re: [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public
Message-ID: <20170331133923.GB6019@potion>
References: <1490961203-7139-1-git-send-email-pbonzini@redhat.com>
 <1490961203-7139-3-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1490961203-7139-3-git-send-email-pbonzini@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 586
Lines: 14

2017-03-31 13:53+0200, Paolo Bonzini:
> Its value has never changed; we might as well make it part of the ABI instead
> of using the return value of KVM_CHECK_EXTENSION(KVM_CAP_COALESCED_MMIO).
> 
> Because PPC does not always make MMIO available, the code has to be made
> dependent on CONFIG_KVM_MMIO rather than KVM_COALESCED_MMIO_PAGE_OFFSET.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

I like the change to CONFIG_KVM_MMIO and the interface isn't suited for
dynamic offsets based on enabled features anyway ...

Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>