Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931AbdCaODT (ORCPT ); Fri, 31 Mar 2017 10:03:19 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48197 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754597AbdCaODS (ORCPT ); Fri, 31 Mar 2017 10:03:18 -0400 Subject: Re: [PATCH v2] xen,kdump: handle pv domain in paddr_vmcoreinfo_note() To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170331101438.28582-1-jgross@suse.com> Cc: ptesarik@suse.com From: Boris Ostrovsky Message-ID: Date: Fri, 31 Mar 2017 10:02:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170331101438.28582-1-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 18 On 03/31/2017 06:14 AM, Juergen Gross wrote: > For kdump to work correctly it needs the physical address of > vmcoreinfo_note. When running as dom0 this means the virtual address > has to be translated to the related machine address. > > paddr_vmcoreinfo_note() is meant to do the translation via > __pa_symbol() only, but being attributed "weak" it can be replaced > easily in Xen case. > > Signed-off-by: Juergen Gross Similar to Jan's concern, if bare-metal x86 people decide to have their own paddr_vmcoreinfo_note() (and they usually build with !CONFIG_XEN) we will have to update this again. I suppose we can deal with that if/when it happens since we will discover this immediately. Reviewed-by: Boris Ostrovsky