Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933467AbdCaOOV (ORCPT ); Fri, 31 Mar 2017 10:14:21 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25119 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933199AbdCaOOS (ORCPT ); Fri, 31 Mar 2017 10:14:18 -0400 Subject: Re: [PATCH 2/2] xen: make functions in xen-acpi-processor return void To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170331111948.17539-1-jgross@suse.com> <20170331111948.17539-3-jgross@suse.com> Cc: konrad.wilk@oracle.com From: Boris Ostrovsky Message-ID: <1efbe39f-1fc2-aaf4-a2b5-c75a63b49fac@oracle.com> Date: Fri, 31 Mar 2017 10:13:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170331111948.17539-3-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 356 Lines: 11 On 03/31/2017 07:19 AM, Juergen Gross wrote: > The return value of xen_copy_pct_data() is always 0 and never checked. > xen_copy_psd_data() returns always 0, too, so checking the value is > kind of pointless. > > Make the functions return void. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky