Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933456AbdCaP3b (ORCPT ); Fri, 31 Mar 2017 11:29:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:33174 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933115AbdCaP3a (ORCPT ); Fri, 31 Mar 2017 11:29:30 -0400 Subject: Re: [PATCH v2] xen: make functions in xen-acpi-processor return void To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170331144056.9759-1-jgross@suse.com> Cc: konrad.wilk@oracle.com From: Juergen Gross Message-ID: <8740ea5c-826d-337b-4e9b-914a8a3e133d@suse.com> Date: Fri, 31 Mar 2017 17:29:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1585 Lines: 45 On 31/03/17 17:13, Boris Ostrovsky wrote: > On 03/31/2017 10:40 AM, Juergen Gross wrote: >> There are several functions in xen-acpi-processor which either always >> return the same value or where the returned value is never checked. >> >> Make the functions return void. >> >> Signed-off-by: Juergen Gross >> --- >> drivers/xen/xen-acpi-processor.c | 51 +++++++++++++++------------------------- >> 1 file changed, 19 insertions(+), 32 deletions(-) >> >> diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c >> index 23e391d..45be017 100644 >> --- a/drivers/xen/xen-acpi-processor.c >> +++ b/drivers/xen/xen-acpi-processor.c >> @@ -54,7 +54,7 @@ static unsigned long *acpi_id_present; >> /* And if there is an _CST definition (or a PBLK) for the ACPI IDs */ >> static unsigned long *acpi_id_cst_present; >> >> -static int push_cxx_to_hypervisor(struct acpi_processor *_pr) >> +static void push_cxx_to_hypervisor(struct acpi_processor *_pr) >> { >> struct xen_platform_op op = { >> .cmd = XENPF_set_processor_pminfo, >> @@ -70,7 +70,7 @@ static int push_cxx_to_hypervisor(struct acpi_processor *_pr) >> dst_cx_states = kcalloc(_pr->power.count, >> sizeof(struct xen_processor_cx), GFP_KERNEL); >> if (!dst_cx_states) >> - return -ENOMEM; >> + return; > > Maybe pr_warn(_once)()? I don't think so. Memory shortage is probably detectable without that message. Adding another (random) message will do more harm than good. Juergen > > In any case: > > Reviewed-by: Boris Ostrovsky >