Subject: Re: [PATCH v2] xen: make functions in xen-acpi-processor return void
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
References: <20170331144056.9759-1-jgross@suse.com>
 <20170331151559.GL19376@char.us.oracle.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
        boris.ostrovsky@oracle.com
From: Juergen Gross <jgross@suse.com>
Message-ID: <c967f4f9-d314-2df5-4005-fb994b8d9448@suse.com>
Date: Fri, 31 Mar 2017 17:30:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170331151559.GL19376@char.us.oracle.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 635
Lines: 19

On 31/03/17 17:15, Konrad Rzeszutek Wilk wrote:
> On Fri, Mar 31, 2017 at 04:40:56PM +0200, Juergen Gross wrote:
>> There are several functions in xen-acpi-processor which either always
>> return the same value or where the returned value is never checked.
>>
>> Make the functions return void.
> 
> Well, we could actually check it and do some extra error reporting?
> (Does it even make sense?)
> 
> Granted the code was done this way so that if we did fail - we would
> try to continue on instead of giving up.
> 
> Perhaps you can include that in the commit description? Thanks

Okay. I'll change the commit description.


Juergen