Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261322AbTE1Wfm (ORCPT ); Wed, 28 May 2003 18:35:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261328AbTE1Wfm (ORCPT ); Wed, 28 May 2003 18:35:42 -0400 Received: from pizda.ninka.net ([216.101.162.242]:49568 "EHLO pizda.ninka.net") by vger.kernel.org with ESMTP id S261322AbTE1Wfl (ORCPT ); Wed, 28 May 2003 18:35:41 -0400 Date: Wed, 28 May 2003 15:47:20 -0700 (PDT) Message-Id: <20030528.154720.74745668.davem@redhat.com> To: zippel@linux-m68k.org Cc: mika.penttila@kolumbus.fi, rmk@arm.linux.org.uk, akpm@digeo.com, hugh@veritas.com, LW@karo-electronics.de, linux-kernel@vger.kernel.org Subject: Re: [patch] cache flush bug in mm/filemap.c (all kernels >= 2.5.30(at least)) From: "David S. Miller" In-Reply-To: References: <20030527.142233.71088632.davem@redhat.com> X-FalunGong: Information control. X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 876 Lines: 20 From: Roman Zippel Date: Wed, 28 May 2003 18:35:15 +0200 (CEST) set_pte() establishes the mapping, this means another cpu can get the pte and start reading the data e.g. into the instruction cache, but if that cpu still has dirty data in the data cache (e.g. a write() or a disk read), the following update_mmu_cache() might be too late. If that really matters for you, your set_pte() could add this operation to a list of pending set_pte()'s in the mm_struct arch specific context area. Then at update_mmu_cache() it runs this list of todo items. I don't see the problem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/