Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755442AbdCaUxd (ORCPT ); Fri, 31 Mar 2017 16:53:33 -0400 Received: from mx0.arrikto.com ([212.71.252.59]:54967 "EHLO mx0.arrikto.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753430AbdCaUxc (ORCPT ); Fri, 31 Mar 2017 16:53:32 -0400 X-Greylist: delayed 428 seconds by postgrey-1.27 at vger.kernel.org; Fri, 31 Mar 2017 16:53:32 EDT Date: Fri, 31 Mar 2017 23:46:22 +0300 From: Ilias Tsitsimpis To: lixiubo@cmss.chinamobile.com Cc: nab@linux-iscsi.org, mchristi@redhat.com, agrover@redhat.com, namei.unix@gmail.com, sheng@yasker.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tcmu: Skip Data-Out blocks before gathering Data-In buffer for BIDI case Message-ID: <20170331204622.pjlvgb5xchboejhz@iliastsi-m.arr> References: <1490927725-25131-1-git-send-email-lixiubo@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490927725-25131-1-git-send-email-lixiubo@cmss.chinamobile.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 707 Lines: 23 Hi Xiubo, On Fri, Mar 31, 2017 at 10:35AM, lixiubo@cmss.chinamobile.com wrote: > From: Xiubo Li > > For the bidirectional case, the Data-Out buffer blocks will always at > the head of the tcmu_cmd's bitmap, and before gathering the Data-In > buffer, first of all it should skip the Data-Out ones, or the device > supporting BIDI commands won't work. > > Fixed: 26418649eead ("target/user: Introduce data_bitmap, replace > data_length/data_head/data_tail") > Reported-by: Ilias Tsitsimpis > Signed-off-by: Xiubo Li Thanks for taking care of this. Tested-by: Ilias Tsitsimpis Best, -- Ilias