Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933370AbdCaXb5 (ORCPT ); Fri, 31 Mar 2017 19:31:57 -0400 Received: from mga07.intel.com ([134.134.136.100]:39708 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932868AbdCaXbz (ORCPT ); Fri, 31 Mar 2017 19:31:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,254,1486454400"; d="scan'208";a="72389839" From: Kuppuswamy Sathyanarayanan To: andy@infradead.org, qipeng.zha@intel.com, dvhart@infradead.org, linux@roeck-us.net Cc: wim@iguana.be, sathyaosid@gmail.com, david.e.box@linux.intel.com, rajneesh.bhardwaj@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: [PATCH v4 1/5] platform/x86: intel_pmc_ipc: fix gcr offset Date: Fri, 31 Mar 2017 16:27:48 -0700 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: <20170331133728.GA23725@rajaneesh-OptiPlex-9010> References: <20170331133728.GA23725@rajaneesh-OptiPlex-9010> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 30 According to Broxton APL PMC spec, gcr mem region starts at offset 0x1000 from ipc mem base address. In this driver, PLAT_RESOURCE_GCR_OFFSET macro defines the offset of GCR memory region from IPC mem region. So we should use 0x1000(4K) as GCR offset. But currently this driver uses 0x1008 as GCT offset.This patch fixes this issue. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/platform/x86/intel_pmc_ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changes since v3: * Updated the commit history diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c index 0651d47..0a33592 100644 --- a/drivers/platform/x86/intel_pmc_ipc.c +++ b/drivers/platform/x86/intel_pmc_ipc.c @@ -82,7 +82,7 @@ /* exported resources from IFWI */ #define PLAT_RESOURCE_IPC_INDEX 0 #define PLAT_RESOURCE_IPC_SIZE 0x1000 -#define PLAT_RESOURCE_GCR_OFFSET 0x1008 +#define PLAT_RESOURCE_GCR_OFFSET 0x1000 #define PLAT_RESOURCE_GCR_SIZE 0x1000 #define PLAT_RESOURCE_BIOS_DATA_INDEX 1 #define PLAT_RESOURCE_BIOS_IFACE_INDEX 2 -- 2.7.4