Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261704AbTE1XcG (ORCPT ); Wed, 28 May 2003 19:32:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261710AbTE1XcG (ORCPT ); Wed, 28 May 2003 19:32:06 -0400 Received: from nat-pool-rdu.redhat.com ([66.187.233.200]:50023 "EHLO devserv.devel.redhat.com") by vger.kernel.org with ESMTP id S261704AbTE1XcE (ORCPT ); Wed, 28 May 2003 19:32:04 -0400 Date: Wed, 28 May 2003 19:45:20 -0400 From: Pete Zaitcev Message-Id: <200305282345.h4SNjKv02989@devserv.devel.redhat.com> To: Richard Braakman cc: linux-kernel@vger.kernel.org Subject: Re: Patch for strncmp use in s390 in 2.5 In-Reply-To: References: <20030528162019.A3492@devserv.devel.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 17 >> I didn't see this posted before. Sorry if I missed it. >> It's a harmless buglet which causes false positives with correctness >> checking tools, and so annoys me. > > Are you sure it's harmless? Your patch changes the meaning from an > exact match to a prefix match. I think it's intended to be an exact > match, but I don't know why it doesn't just use strcmp(). The buglet is harmless. Now, the fix perhaps not. I think it may be better to replace it with strcmp, too. -- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/