Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbdDATSP (ORCPT ); Sat, 1 Apr 2017 15:18:15 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:56892 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751804AbdDATSO (ORCPT ); Sat, 1 Apr 2017 15:18:14 -0400 Date: Sat, 01 Apr 2017 12:18:12 -0700 (PDT) Message-Id: <20170401.121812.2065199697531175615.davem@davemloft.net> To: yihung.wei@gmail.com Cc: jbenc@redhat.com, joe@ovn.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update() From: David Miller In-Reply-To: <1490902563-19288-1-git-send-email-yihung.wei@gmail.com> References: <1490902563-19288-1-git-send-email-yihung.wei@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 01 Apr 2017 11:36:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 15 From: Yi-Hung Wei Date: Thu, 30 Mar 2017 12:36:03 -0700 > ovs_flow_key_update() is called when the flow key is invalid, and it is > used to update and revalidate the flow key. Commit 329f45bc4f19 > ("openvswitch: add mac_proto field to the flow key") introduces mac_proto > field to flow key and use it to determine whether the flow key is valid. > However, the commit does not update the code path in ovs_flow_key_update() > to revalidate the flow key which may cause BUG_ON() on execute_recirc(). > This patch addresses the aforementioned issue. > > Fixes: 329f45bc4f19 ("openvswitch: add mac_proto field to the flow key") > Signed-off-by: Yi-Hung Wei Applied and queued up for -stable, thanks.