Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751008AbdDBFgE (ORCPT ); Sun, 2 Apr 2017 01:36:04 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35990 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbdDBFgB (ORCPT ); Sun, 2 Apr 2017 01:36:01 -0400 From: Andi Shyti X-Google-Original-From: Andi Shyti To: MyungJoo Ham , Chanwoo Choi , Jaewon Kim Cc: Seung-Woo Kim , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v2 1/2] extcon: max77843: improve the code and minimize duplicated lines Date: Sun, 2 Apr 2017 14:35:41 +0900 Message-Id: <20170402053542.29570-2-andi@etezian.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170402053542.29570-1-andi@etezian.org> References: <20170402053542.29570-1-andi@etezian.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1776 Lines: 59 From: Andi Shyti Signed-off-by: Andi Shyti --- drivers/extcon/extcon-max77843.c | 33 ++++++++------------------------- 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c index 6e722d552cf1..fcdabc4b4025 100644 --- a/drivers/extcon/extcon-max77843.c +++ b/drivers/extcon/extcon-max77843.c @@ -264,37 +264,20 @@ static int max77843_muic_get_cable_type(struct max77843_muic_info *info, chg_type = info->status[MAX77843_MUIC_STATUS2] & MAX77843_MUIC_STATUS2_CHGTYP_MASK; - /* Check GROUND accessory with charger cable */ - if (adc == MAX77843_MUIC_ADC_GROUND) { - if (chg_type == MAX77843_MUIC_CHG_NONE) { - /* - * The following state when charger cable is - * disconnected but the GROUND accessory still - * connected. - */ - *attached = false; - cable_type = info->prev_chg_type; - info->prev_chg_type = MAX77843_MUIC_CHG_NONE; - } else { - - /* - * The following state when charger cable is - * connected on the GROUND accessory. - */ - *attached = true; - cable_type = MAX77843_MUIC_CHG_GND; - info->prev_chg_type = MAX77843_MUIC_CHG_GND; - } - break; - } - if (chg_type == MAX77843_MUIC_CHG_NONE) { *attached = false; cable_type = info->prev_chg_type; info->prev_chg_type = MAX77843_MUIC_CHG_NONE; } else { *attached = true; - cable_type = info->prev_chg_type = chg_type; + switch (adc) { + case MAX77843_MUIC_ADC_GROUND: + info->prev_chg_type = MAX77843_MUIC_CHG_GND; + break; + default: + info->prev_chg_type = chg_type; + } + cable_type = info->prev_chg_type; } break; case MAX77843_CABLE_GROUP_ADC_GND: -- 2.11.0