Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750842AbdDBGCg (ORCPT ); Sun, 2 Apr 2017 02:02:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49406 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbdDBGCf (ORCPT ); Sun, 2 Apr 2017 02:02:35 -0400 Date: Sun, 2 Apr 2017 08:02:19 +0200 From: Greg KH To: Daniel Cashman Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6656: Fix spaces, char limit and embedded func name in print. Message-ID: <20170402060219.GA7499@kroah.com> References: <1491103740-5811-1-git-send-email-dan.a.cashman@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491103740-5811-1-git-send-email-dan.a.cashman@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 505 Lines: 14 On Sat, Apr 01, 2017 at 08:29:00PM -0700, Daniel Cashman wrote: > From: Dan Cashman > > Address errors and warning found in rf.c by checkpatch kernel style script. > Specifically, change spaces to tabs, split function arguments across a new > line to avoid 80 character limit, and remove use of embedded function name > in a dev_dbg() call. That's a lot of different things all in one patch, please break this up into doing only one type of thing per patch. thanks, greg k-h