Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750944AbdDBIJX (ORCPT ); Sun, 2 Apr 2017 04:09:23 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:46986 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbdDBIJT (ORCPT ); Sun, 2 Apr 2017 04:09:19 -0400 Subject: Re: [PATCH v2] iio: light: lm3533-als: constify attribute_group structures To: simran singhal References: <20170330184038.GA11591@singhal-Inspiron-5558> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com From: Jonathan Cameron Message-ID: Date: Sun, 2 Apr 2017 09:09:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170330184038.GA11591@singhal-Inspiron-5558> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2326 Lines: 83 On 30/03/17 19:40, simran singhal wrote: > Check for attribute_group structures that are only stored in the > event_attrs filed of iio_info structure. As the event_attrs field of > iio_info structures is constant, so these attribute_group structures can > also be declared constant. Done using coccinelle: > > @r1 disable optional_qualifier @ > identifier i; > position p; > @@ > static struct attribute_group i@p = {...}; > > @ok1@ > identifier r1.i; > position p; > struct iio_info x; > @@ > x.event_attrs=&i@p; > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > static > +const > struct attribute_group i={...}; > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct attribute_group i; > > As the attrs field of iio_info structures is also constant, so these > attribute_group structures can also be declared constant. Done manually. > > File size before: > text data bss dec hex filename > 5798 2376 0 8174 1fee drivers/iio/light/lm3533-als.o > > File size after: > text data bss dec hex filename > 5926 2248 0 8174 1fee drivers/iio/light/lm3533-als.o > > Signed-off-by: simran singhal Applied. > --- > v2: > -make one more attribute_group const. > -change the values of file size after. > -change commit message. > > drivers/iio/light/lm3533-als.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index f409c20..0443fd2 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > @@ -690,7 +690,7 @@ static struct attribute *lm3533_als_event_attributes[] = { > NULL > }; > > -static struct attribute_group lm3533_als_event_attribute_group = { > +static const struct attribute_group lm3533_als_event_attribute_group = { > .attrs = lm3533_als_event_attributes > }; > > @@ -714,7 +714,7 @@ static struct attribute *lm3533_als_attributes[] = { > NULL > }; > > -static struct attribute_group lm3533_als_attribute_group = { > +static const struct attribute_group lm3533_als_attribute_group = { > .attrs = lm3533_als_attributes > }; > >