Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbdDBIvZ (ORCPT ); Sun, 2 Apr 2017 04:51:25 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:47269 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbdDBIvX (ORCPT ); Sun, 2 Apr 2017 04:51:23 -0400 Subject: Re: [PATCH] iio: humidity: hts221_buffer: Remove unnecessary cast on void pointer To: simran singhal References: <20170401141415.GA29239@singhal-Inspiron-5558> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: Date: Sun, 2 Apr 2017 09:51:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170401141415.GA29239@singhal-Inspiron-5558> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 47 On 01/04/17 15:14, simran singhal wrote: > The following Coccinelle script was used to detect this: > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > - (T*) > e > ) > > Signed-off-by: simran singhal I made a miinor change to the title to drop the _buffer. That's naming the exact file, whereas keeping it to the driver is fine (so just hts221). Applied. Thanks, Jonathan > --- > drivers/iio/humidity/hts221_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c > index 72ddcda..7d19a3d 100644 > --- a/drivers/iio/humidity/hts221_buffer.c > +++ b/drivers/iio/humidity/hts221_buffer.c > @@ -41,7 +41,7 @@ static const struct iio_trigger_ops hts221_trigger_ops = { > > static irqreturn_t hts221_trigger_handler_thread(int irq, void *private) > { > - struct hts221_hw *hw = (struct hts221_hw *)private; > + struct hts221_hw *hw = private; > u8 status; > int err; > >