Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751458AbdDBM4C (ORCPT ); Sun, 2 Apr 2017 08:56:02 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:36656 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbdDBM4A (ORCPT ); Sun, 2 Apr 2017 08:56:00 -0400 MIME-Version: 1.0 In-Reply-To: <20170401222119.25106-4-nicolas.pitre@linaro.org> References: <20170401222119.25106-1-nicolas.pitre@linaro.org> <20170401222119.25106-4-nicolas.pitre@linaro.org> From: Andy Shevchenko Date: Sun, 2 Apr 2017 15:55:58 +0300 Message-ID: Subject: Re: [PATCH v2 3/5] serial: small Makefile reordering To: Nicolas Pitre Cc: Greg Kroah-Hartman , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 46 On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre wrote: > Move 21285 entry down alongside other UART drivers to be more consistent > with the rest of the file. It is kept before 8250 though, to preserve the > existing link ordering between those two. I did once for entire Makefile (some logical reordering), but Greg objected it. Perhaps you can sell it better. http://www.spinics.net/lists/linux-serial/msg23616.html > > Signed-off-by: Nicolas Pitre > --- > drivers/tty/serial/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile > index 2d6288bc45..53c03e0051 100644 > --- a/drivers/tty/serial/Makefile > +++ b/drivers/tty/serial/Makefile > @@ -3,7 +3,6 @@ > # > > obj-$(CONFIG_SERIAL_CORE) += serial_core.o > -obj-$(CONFIG_SERIAL_21285) += 21285.o > > obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o > obj-$(CONFIG_SERIAL_EARLYCON_ARM_SEMIHOST) += earlycon-arm-semihost.o > @@ -17,6 +16,8 @@ obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o > obj-$(CONFIG_SERIAL_SUNSU) += sunsu.o > obj-$(CONFIG_SERIAL_SUNSAB) += sunsab.o > > +obj-$(CONFIG_SERIAL_21285) += 21285.o > + > # Now bring in any enabled 8250/16450/16550 type drivers. > obj-$(CONFIG_SERIAL_8250) += 8250/ > > -- > 2.9.3 > -- With Best Regards, Andy Shevchenko