Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446AbdDBNQ3 (ORCPT ); Sun, 2 Apr 2017 09:16:29 -0400 Received: from mail-qt0-f178.google.com ([209.85.216.178]:33439 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbdDBNQ1 (ORCPT ); Sun, 2 Apr 2017 09:16:27 -0400 MIME-Version: 1.0 In-Reply-To: <20170401222119.25106-5-nicolas.pitre@linaro.org> References: <20170401222119.25106-1-nicolas.pitre@linaro.org> <20170401222119.25106-5-nicolas.pitre@linaro.org> From: Andy Shevchenko Date: Sun, 2 Apr 2017 16:16:26 +0300 Message-ID: Subject: Re: [PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file To: Nicolas Pitre Cc: Greg Kroah-Hartman , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 404 Lines: 12 On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre wrote: > This contains code that is common between serial_core.c and the > minitty code to come. Mainly helper functions used by UART drivers. I have two questions: - why minitty (what is that by the way?) can't use serial_core.c as a library? - does -M -C help to make this diff shorter? -- With Best Regards, Andy Shevchenko