Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdDBPot (ORCPT ); Sun, 2 Apr 2017 11:44:49 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:33167 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbdDBPor (ORCPT ); Sun, 2 Apr 2017 11:44:47 -0400 Date: Sun, 2 Apr 2017 11:44:45 -0400 (EDT) From: Nicolas Pitre To: Andy Shevchenko cc: Greg Kroah-Hartman , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm Mailing List Subject: Re: [PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file In-Reply-To: Message-ID: References: <20170401222119.25106-1-nicolas.pitre@linaro.org> <20170401222119.25106-5-nicolas.pitre@linaro.org> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 21 On Sun, 2 Apr 2017, Andy Shevchenko wrote: > On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre wrote: > > This contains code that is common between serial_core.c and the > > minitty code to come. Mainly helper functions used by UART drivers. > > > I have two questions: > - why minitty (what is that by the way?) can't use serial_core.c as a library? See patch 5/5. It is a compatible replacement for serial_core.c and the entire TTY layer collapsed into the smallest code possible, and the result is itself smaller than serial_core.c alone. > - does -M -C help to make this diff shorter? No it doesn't. Maybe I should have mentioned that there is no functional change resulting from this patch. Nicolas