Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751517AbdDBRaW (ORCPT <rfc822;w@1wt.eu>);
        Sun, 2 Apr 2017 13:30:22 -0400
Received: from mout.kundenserver.de ([212.227.126.133]:64377 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750916AbdDBRaU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Apr 2017 13:30:20 -0400
Date: Sun, 2 Apr 2017 19:29:49 +0200
From: Andreas Klinger <ak@it-klinger.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
        Matt Ranostay <matt.ranostay@intel.com>,
        Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>, ddvlad@gmail.com,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        Aniroop Mathur <a.mathur@samsung.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation
Message-ID: <20170402172949.GA1479@project>
References: <20170327100646.GA8128@project>
 <2bec8c26-f33c-d331-aa97-047871b4cc57@kernel.org>
 <CACRpkdb06PcUwC_zRThLXcw=haiDzuqP-gsVjchNnSWkootT0Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACRpkdb06PcUwC_zRThLXcw=haiDzuqP-gsVjchNnSWkootT0Q@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Provags-ID: V03:K0:watVdGnfO5QQ/oIaCktvp0ZuWp/Uq5zpvq/Gm1zLsT7N97VDEos
 ENl4Nk/brP4tEnQrsza/blA+7gt4wfiZEJQKVWJUku+WUWcN67LboKhr/ACreuUi8lfKXjF
 Y1g0Tu5GQ3nNUuhI2ZMuGiewXQPIv1+T3tdtdhh9K7MUG4rGqH6VecuAjhVf3IzoOWEo1YA
 IB/wYkX+M/3BwlaFvF7kg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:FrgVC3sKVWw=:8ZK+Az9wFPTGa9uW3X4tEP
 izT2FEgf81YQMUMC8iErMAip+QcCha4J/ZiG5V/q02K6ZomTw0+xcHerzIbWfktBEBlkaOTjq
 +1NYTlmd5gjuz6fFquIElVqmPaighbSdPQmkeRQ7bhkfXhk7UVwpwReOgKK5AheprIJ3Pvbpq
 jfxF5FHTFG7RnVKeYa9e1bOJPYmLClZMvaz4K9hcS4lVA2SVoQCsEfkYFqWRM993uqD5W736+
 0lsfeIsbQd5r32VIU3oQtKsRHbT0STfNMl1hIcC1f4EQPScVxpPClH+CTobQ8Sx4mdk55FreU
 DbMhQFIenyryweXVSHbmX9DaDLBoYHm87SrGXK+pMYVXLitGVaKkdsNxBugb2Aex1eEccSJzC
 8ENn8bviQK9CBvjeL3A8SkNNxN+cdYSR8Ua9sH5XoO6q7nuo0B1blDOHsDt8OEULQWij/ilhd
 UJJ+C/Knb4Ac5tYLg1sNWyjpFdJ5nJwtZCkW0kh6H2kDn/L5A4u4tUUOdpBOBDiXPF0EBkrT4
 +X2otEg02B4X6/hSuIPrQFhlFkbELxJ3okG3fgqKRmSSuFEKl9mpVHtn8pkzosJO9QCMgenRT
 c4gNrXrosQYk+uVLF01lCYc0d3Ue/oScBTDurotn/Dnzmm69MNxF35lwUDhVGoQYS/VI06yLM
 cTkiIGWryEkYpFailr48DpzHYxfy8mj3T0siO+8kuVOgOXD98IwT3/Pb21Fr+a4s1jS0=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1041
Lines: 31

Linus Walleij <linus.walleij@linaro.org> schrieb am Sun, 02. Apr 16:56:
> On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> > On 27/03/17 11:06, Andreas Klinger wrote:
> >> While calculating the compensation of the humidity there are negative
> >> values interpreted as unsigned because of unsigned variables used.
> >> These values need to be casted to signed as indicated by the documentation
> >> of the sensor.
> >>
> >> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> >
> > Looks superficially right to me, but would like an Ack from Linus Walleij.
> 
> I didn't work on these calculations, only infrastructure for the driver
> but FWIW:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Matt Ranostay @Intel is the person you probably want to ACK it though,
> he added the humidity calculations :)

It just turned out that there must be another error in the calculation. I'll fix
and test it first.

When i'm done i'll send a new version of the patch.

Andreas

> 
> Yours,
> Linus Walleij

--