Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751543AbdDBRqv convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Sun, 2 Apr 2017 13:46:51 -0400
Received: from saturn.retrosnub.co.uk ([178.18.118.26]:50239 "EHLO
        saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750844AbdDBRqu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Apr 2017 13:46:50 -0400
Date: Sun, 02 Apr 2017 18:46:43 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <20170402172949.GA1479@project>
References: <20170327100646.GA8128@project> <2bec8c26-f33c-d331-aa97-047871b4cc57@kernel.org> <CACRpkdb06PcUwC_zRThLXcw=haiDzuqP-gsVjchNnSWkootT0Q@mail.gmail.com> <20170402172949.GA1479@project>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation
To: Andreas Klinger <ak@it-klinger.de>,
        Linus Walleij <linus.walleij@linaro.org>
CC: Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>, ddvlad@gmail.com,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        Aniroop Mathur <a.mathur@samsung.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        matt.ranostay@konsulko.com
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Message-ID: <9FFBD449-625B-46A5-A6FD-D23A41E5EB9D@jic23.retrosnub.co.uk>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1246
Lines: 44



On 2 April 2017 18:29:49 BST, Andreas Klinger <ak@it-klinger.de> wrote:
>Linus Walleij <linus.walleij@linaro.org> schrieb am Sun, 02. Apr 16:56:
>> On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <jic23@kernel.org>
>wrote:
>> > On 27/03/17 11:06, Andreas Klinger wrote:
>> >> While calculating the compensation of the humidity there are
>negative
>> >> values interpreted as unsigned because of unsigned variables used.
>> >> These values need to be casted to signed as indicated by the
>documentation
>> >> of the sensor.
>> >>
>> >> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
>> >
>> > Looks superficially right to me, but would like an Ack from Linus
>Walleij.
>> 
>> I didn't work on these calculations, only infrastructure for the
>driver
>> but FWIW:
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>> 
>> Matt Ranostay @Intel is the person you probably want to ACK it
>though,
>> he added the humidity calculations :)
He's now at Konsulko.
Ccd
>
>It just turned out that there must be another error in the calculation.
>I'll fix
>and test it first.
>
>When i'm done i'll send a new version of the patch.
>
>Andreas
>
>> 
>> Yours,
>> Linus Walleij

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.