Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdDBXUV (ORCPT ); Sun, 2 Apr 2017 19:20:21 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:55149 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbdDBXUT (ORCPT ); Sun, 2 Apr 2017 19:20:19 -0400 Message-ID: <1491175217.8846.60.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH] tcmu: Skip Data-Out blocks before gathering Data-In buffer for BIDI case From: "Nicholas A. Bellinger" To: lixiubo@cmss.chinamobile.com Cc: mchristi@redhat.com, agrover@redhat.com, iliastsi@arrikto.com, namei.unix@gmail.com, sheng@yasker.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 02 Apr 2017 16:20:17 -0700 In-Reply-To: <1490927725-25131-1-git-send-email-lixiubo@cmss.chinamobile.com> References: <1490927725-25131-1-git-send-email-lixiubo@cmss.chinamobile.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 19 On Fri, 2017-03-31 at 10:35 +0800, lixiubo@cmss.chinamobile.com wrote: > From: Xiubo Li > > For the bidirectional case, the Data-Out buffer blocks will always at > the head of the tcmu_cmd's bitmap, and before gathering the Data-In > buffer, first of all it should skip the Data-Out ones, or the device > supporting BIDI commands won't work. > > Fixed: 26418649eead ("target/user: Introduce data_bitmap, replace > data_length/data_head/data_tail") > Reported-by: Ilias Tsitsimpis > Signed-off-by: Xiubo Li > --- > drivers/target/target_core_user.c | 48 +++++++++++++++++++++++++++------------ > 1 file changed, 33 insertions(+), 15 deletions(-) Applied to target-pending/master, with a CC' to linux-4.6.y stable. Thanks Xiubo + Ilias.