Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbdDCCwi (ORCPT ); Sun, 2 Apr 2017 22:52:38 -0400 Received: from mga02.intel.com ([134.134.136.20]:42761 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdDCCwg (ORCPT ); Sun, 2 Apr 2017 22:52:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,267,1486454400"; d="scan'208";a="841092371" Date: Mon, 3 Apr 2017 10:52:29 +0800 From: Fengguang Wu To: David Miller Cc: salil.mehta@huawei.com, netdev@vger.kernel.org, mehta.salil.lnk@gmail.com, linux-kernel@vger.kernel.org, linuxarm@huawei.com, kbuild-all@01.org, lipeng321@huawei.com, yisen.zhuang@huawei.com, lkp@intel.com Subject: Re: [kbuild-all] [PATCH] net: hns: fix boolreturn.cocci warnings Message-ID: <20170403025229.4s5phuckehwmucbt@wfg-t540p.sh.intel.com> References: <201704010733.8LNMN4m7%fengguang.wu@intel.com> <20170330153106.14344-9-salil.mehta@huawei.com> <20170331235055.GA28462@lkp-wsm-ep1> <20170402.194402.639435117868426012.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170402.194402.639435117868426012.davem@davemloft.net> User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 31 Hi David, On Sun, Apr 02, 2017 at 07:44:02PM -0700, David Miller wrote: >From: kbuild test robot >Date: Sat, 1 Apr 2017 07:50:55 +0800 > >> drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1 in function 'hns_enable_serdes_lb' with return type bool >> >> Return statements in functions returning bool should use >> true/false instead of 1/0. >> Generated by: scripts/coccinelle/misc/boolreturn.cocci >> >> CC: lipeng >> Signed-off-by: Fengguang Wu > >This doesn't apply to any of my trees. It's a reply to Salil's patch [PATCH net 08/19] net: hns: Fix to adjust buf_size of ring according to mtu and so is based on that patch. What can the robot improve to avoid you confusing it as a general patch for the net master trees? One possible way is to change title to [PATCH for Salil] net: hns: fix boolreturn.cocci warnings ^^^^^^^^^^^^^^^^^ Regards, Fengguang