Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbdDCFc3 convert rfc822-to-8bit (ORCPT ); Mon, 3 Apr 2017 01:32:29 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:39528 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbdDCFc2 (ORCPT ); Mon, 3 Apr 2017 01:32:28 -0400 From: Minas Harutyunyan To: Felipe Balbi , Minas Harutyunyan , John Youn , "Greg Kroah-Hartman" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dwc2: gadget: Fix in control write transfers Thread-Topic: [PATCH] dwc2: gadget: Fix in control write transfers Thread-Index: AQHSp8vRhVu3/T7nok2dbU4OmYx1+w== Date: Mon, 3 Apr 2017 05:32:23 +0000 Message-ID: <410670D7E743164D87FA6160E7907A56FD9F6775@am04wembxb.internal.synopsys.com> References: <07102b18cb19dd576017b0259a2fb54a663af39f.1490723930.git.hminas@synopsys.com> <87a883jbag.fsf@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.116.70.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 22 Hi, On 3/30/2017 2:42 PM, Felipe Balbi wrote: > > Hi, > > Minas Harutyunyan writes: >> After data out stage gadget driver should not initate ZLP on control EP, >> because it is up to function driver. > > not true always, depends on return value from ->setup(). Which problem > did you have? Which gadget driver? How did you reproduce? Which other > tests did you run on this patch? > This required for delayed status support. Tested with Synopsys test gadget. As host used USB tracer traffic generator (different control transfers scenarios). Also performed smoke tests with mass storage function to detect any side effects. Thanks, Minas