Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbdDCHlO (ORCPT ); Mon, 3 Apr 2017 03:41:14 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34384 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbdDCHlN (ORCPT ); Mon, 3 Apr 2017 03:41:13 -0400 Date: Mon, 3 Apr 2017 09:41:01 +0200 From: Daniel Vetter To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, zyw@rock-chips.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered Message-ID: <20170403074101.f3ykqpdphklwummz@phenom.ffwll.local> Mail-Followup-To: Jeffy Chen , linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, zyw@rock-chips.com, linux-arm-kernel@lists.infradead.org References: <1491046529-4310-1-git-send-email-jeffy.chen@rock-chips.com> <1491046529-4310-9-git-send-email-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491046529-4310-9-git-send-email-jeffy.chen@rock-chips.com> X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1803 Lines: 57 On Sat, Apr 01, 2017 at 07:35:28PM +0800, Jeffy Chen wrote: > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None Wut? How is this even possible? If you haven't registered the driver yet, there's no way for userspace to call allocation functions. Anything else is a driver bug that should be handled by fixing the driver load sequence. The only thing I can imagine is that you init the fbdev stuff too early, in that case pls fix that. Not apply this duct-tape here. Thanks, Daniel > > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > index df9e570..2bf8024 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -184,6 +184,9 @@ static int rockchip_gem_alloc_buf(struct rockchip_gem_object *rk_obj, > struct drm_device *drm = obj->dev; > struct rockchip_drm_private *private = drm->dev_private; > > + if (!drm->registered) > + return -ENODEV; > + > if (private->domain) > return rockchip_gem_alloc_iommu(rk_obj, alloc_kmap); > else > @@ -208,6 +211,11 @@ static void rockchip_gem_free_dma(struct rockchip_gem_object *rk_obj) > > static void rockchip_gem_free_buf(struct rockchip_gem_object *rk_obj) > { > + struct drm_device *drm = rk_obj->base.dev; > + > + if (!drm->registered) > + return; > + > if (rk_obj->pages) > rockchip_gem_free_iommu(rk_obj); > else > -- > 2.1.4 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch