Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751910AbdDCHpP (ORCPT ); Mon, 3 Apr 2017 03:45:15 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:36479 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbdDCHpN (ORCPT ); Mon, 3 Apr 2017 03:45:13 -0400 MIME-Version: 1.0 In-Reply-To: <20170403070845.10793-3-kraxel@redhat.com> References: <20170403070845.10793-1-kraxel@redhat.com> <20170403070845.10793-3-kraxel@redhat.com> From: Dave Airlie Date: Mon, 3 Apr 2017 17:45:12 +1000 Message-ID: Subject: Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create To: Gerd Hoffmann Cc: dri-devel , lvivier@redhat.com, open list , "open list:VIRTIO GPU DRIVER" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1716 Lines: 47 On 3 April 2017 at 17:08, Gerd Hoffmann wrote: > Lookup format using virtio_gpu_translate_format() > instead of hardcoding it. Fixes xorg display on > bigendian guests (i.e. ppc64). > > Signed-off-by: Gerd Hoffmann For the series, Reviewed-by: Dave Airlie > --- > drivers/gpu/drm/virtio/virtgpu_gem.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_gem.c b/drivers/gpu/drm/virtio/virtgpu_gem.c > index 336a57f..cc025d8 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_gem.c > +++ b/drivers/gpu/drm/virtio/virtgpu_gem.c > @@ -88,6 +88,7 @@ int virtio_gpu_mode_dumb_create(struct drm_file *file_priv, > int ret; > uint32_t pitch; > uint32_t resid; > + uint32_t format; > > pitch = args->width * ((args->bpp + 1) / 8); > args->size = pitch * args->height; > @@ -98,9 +99,10 @@ int virtio_gpu_mode_dumb_create(struct drm_file *file_priv, > if (ret) > goto fail; > > + format = virtio_gpu_translate_format(DRM_FORMAT_XRGB8888); > virtio_gpu_resource_id_get(vgdev, &resid); > - virtio_gpu_cmd_create_resource(vgdev, resid, > - 2, args->width, args->height); > + virtio_gpu_cmd_create_resource(vgdev, resid, format, > + args->width, args->height); > > /* attach the object to the resource */ > obj = gem_to_virtio_gpu_obj(gobj); > -- > 2.9.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel