Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbdDCIiK (ORCPT ); Mon, 3 Apr 2017 04:38:10 -0400 Received: from mail-he1eur01on0124.outbound.protection.outlook.com ([104.47.0.124]:19181 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752351AbdDCIhu (ORCPT ); Mon, 3 Apr 2017 04:37:50 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=axentia.se; From: Peter Rosin To: CC: Peter Rosin , Wolfram Sang , Peter Korsgaard , Guenter Roeck , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mauro Carvalho Chehab , , , Subject: [PATCH 9/9] [media] cx231xx: stop double error reporting Date: Mon, 3 Apr 2017 10:38:38 +0200 Message-ID: <1491208718-32068-10-git-send-email-peda@axentia.se> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1491208718-32068-1-git-send-email-peda@axentia.se> References: <1491208718-32068-1-git-send-email-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM3PR07CA0091.eurprd07.prod.outlook.com (10.165.222.25) To VI1PR0202MB2559.eurprd02.prod.outlook.com (10.173.79.138) X-MS-Office365-Filtering-Correlation-Id: 37c01387-4e79-420e-8eef-08d47a6cb164 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;3:BwYGth/N6WJbWXnBaG5iowDbh2xfzgWapB39wAoPhiNWI6qbbe6BWrfjetXcwvOYkBAnc1mGVCJjJosWvVuHawsPu3mfOAX2lSF+fyMqlHJkhumnS3GThS4o6YSYSXyH3AU2zDsHN/RV/EwiZCvoqwTLvv0jiIpHvnfhLXjBNuXS2b/BA88KSJlvri8TDEvYcwqBe1vVT2MFxK99pxtnkwSrstUohN/akx0WhInuK/KMwLtsK8biS/1iq98NUjDurxr6gSZQQLfADev2uI6s1K6YHv+Y+pMK1vzLp1ukdNC+8rpNWolp8KTOMUVKPI7O;25:OlLntN919MH5J9DVu4+TR0cGVonAAWlXG4iHzIDngSo2IJaQ6bmTxzUBHB/KtrAaw0oTRTAFJCJkWL3C86jaIcjJM/AUn3jYcGz+ZplUGUMciJ2brZBELocEAW5/IZb109HQQE1yVmz9rULJZZ4NXkt+1ucSuBuS0GxgnyUW5DjZzgoG6/hy65JbjDK8zB91/RTTfcfv/fJOaJD9rRSLnQa/0T8SVp5pKbfCehydUGq9Nc+cAooNUCNZ5aMvdy8O5ni4+VwY9jErP0Pc4gUkv6Krb5ThXS1CDDRWFOYoYwlQ5JdEEKVgXfhIYVsecBz6bz56GQvDNheiWRObqC+rni7fntWGOHDuUfomstIWdsQdeXP0+7BRPOt9ZmYGtKoiYLNxKs0lP2HHVtBxHLAxTL3JrAtFSxkSyynHG5tusyuGpdD7xojX9LPEjpjUcuFX2Iiy/5tIRgH6D8vIJ6s9PQ== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;31:iN56wdTvuQ64f5oqrRIhTcttB1Bavyi+B0rtx5KNSnfKicjOKNYlbbYicnD3bDPmtzUK2/RUxQgm9ex2It/cGm2POPnWiqsr1Am9vywElNfKQrObBsTF8ZK8xN4swYZxbKXfp4fWQvi884eM/YO9kOAlHaHG5GxDWB0e6osyz4xH0MJnDGgZn6y3rm9eJhF6PdNbDt82fph6W46cNpPvSHEyoCAhH8+M7rShTmwT2pACOGw2UNqQUP9l/qOnNq14 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(2016111802025)(6043046)(6072148);SRVR:VI1PR0202MB2559;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;4:p70ScmGDyDAEHVZw9GaFuj4gadzSdjkZOevbYpESQHDq4TdX+L1JG+kKfKQrVyDaBZo8KXn0kTLq3W1kmP+WpeQyVaGmr9gZw2ssO7sJRMJgxaWDgn9PsxWyNyWrX+Az9fXBxAt3ifcTSUaWjGbYVvnZjMyNkCbXKVAZZa4ZgZL6yWadccAvVlXgw/ZaWxF4J+UUtyKBc30PFAACaAzh8e3D50DFUJMIminRBY2msDW52jKDRq0+xJLR/1OVYwdyVqmU8LGmc3UaMwlMU/Cc4r8qFBiof51ur6Gxz9z/i+7lmwrn8VKzbSCrTECjRmn/vVkfZYVrowaWKT2VMD0omRoSjCPceOGHPluRg8sXL8WwUgJBpFfaiugW0ANAlSNJwykt4fu1o/lnKL1WPFUF3Z4w/CdcG7gNsnytipUrukQdpq+WS+YDpaQk3OSA/SWd1e/6ZOmGg0XSCCiQXmmF5CsDTtJMtYW101GH4Axs1bpSPuZ4J/IiIjBLQiH1yIG32+E4H9TW4QqpPVgIpMt2XzFnBz0iTDwiEQuU1Lcha0wh3RnejX4LBkI2XwOX9jOGHGEGMkEN5dGzt8HasrUebh/w1m3PYcpeZl0iwA0VAKPaF8x4R8j2SKW3i5MAwj9kVTi1ffSwqEpR/0VVAM9bvYm6lhAmNH8eyhLqpdULw3WukoKy4kUHujd1it8NhEgHN1nrs7o9+coLH0hOXqMBDxwiVlZ9gEIw/AA2bCntB0HjD+I7P9m6c1/UBEMuUIvbQvvQGozF9c2h1/8RusbFXOh2o2AVB2AS1wGOSgC7e18ZCCk7gDMuVw55YrLiX95C X-Forefront-PRVS: 0266491E90 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6069001)(6009001)(39400400002)(39410400002)(39450400003)(39830400002)(74482002)(6916009)(81166006)(6512007)(54906002)(7416002)(86362001)(25786009)(2950100002)(53936002)(8676002)(5660300001)(8666007)(48376002)(2351001)(5003940100001)(33646002)(42186005)(3846002)(6116002)(305945005)(6486002)(7736002)(50226002)(2906002)(50986999)(4326008)(189998001)(36756003)(38730400002)(110136004)(66066001)(76176999)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2559;H:localhost.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0202MB2559;23:D6WJ9urjkTFEDa/fwAgcnV8RIoaJ3d2q4oj2MRl?= =?us-ascii?Q?L1uYjVI+EK9spUh1aWfDN4HhyKQFd03UQtRxAlNfTi0AXcIdjIhVaA8bKVWa?= =?us-ascii?Q?9jYMC2guX1okmj7YeOEa8+vo1tLyoM+p9BBoeiKQowhKJrLvalcA4uT/sx/r?= =?us-ascii?Q?uOt/RRjg1MQNF1CnZGaRI9iY0oJf7bji77dfsggh0/Ucnz2/UBkNNbNZ1rOF?= =?us-ascii?Q?B0LDFypB4Qf4ZK2HaoDcbiSUVZyICy3pNUfaDyhxmawsGOp/aBcOjHWO9X39?= =?us-ascii?Q?LtXXv4NH1muQwr8Yvc93wz45YDz6GYr3O3ptkw1yQPM0prosl9qLoKOkb+rV?= =?us-ascii?Q?BCHjQ1APjhS5VkR5VBsepUu9jcIwCOh/X+wVsVkGz6X4W++YJaGRO5n2JRp0?= =?us-ascii?Q?C7dJK9uYF5Mkezrne441BunlNING3xrE/VvqVz1wvb1yVhBpa0RBVyHBOEP0?= =?us-ascii?Q?/TuRHIpUk4WpCNKBoyT8RCeexLVJgpGYKoMX3pvYe5LwijHjBTH12DTrIqq2?= =?us-ascii?Q?Y/lngzTbBbnk2N7OfEjWKFE64rVyWzY1wa7W67T9caSmEIYwVpvimX9h+3uA?= =?us-ascii?Q?5XJKsK394kNqbeFZpCapX4oHwaa6OCZ4TBBOTX8NsqlAPo7chJ++nVPJ418x?= =?us-ascii?Q?Oe/q27CZPlMfq2dpMYqkvU/x3hizMjOqQ7ffXIcAcRM0/jHgS6Y2T0L2AJ4c?= =?us-ascii?Q?baC42vBw6Vn0vm7AzdUXtbE0X+yE9NNbT8Tq2UYuxUo+II7KKOgeOc6asmyX?= =?us-ascii?Q?l8N/OPL9CklgU9LdsTaHdwJlQoYHwciP+VR0sf4eU+GH/AEsCZtUe/a9+Ucw?= =?us-ascii?Q?7X30OO9ZU4aduntrwsFfkO0/lDddOYm5qnN97s6Bv4c18j18Pp2S9IwzfM+L?= =?us-ascii?Q?QCsOcOZoW9RfOZwEZ7EgtPlvqVLZULa6JHR3uyUiEusTO1BNM193z/oUKAIf?= =?us-ascii?Q?EuCGkjqfyZgtBCbXCiF9tScBEWR0jJY6/PBBKLL7u0TMI2H0XZnZ/sz8o6Le?= =?us-ascii?Q?dmzr3I+oQ9xJ0XLQo9yz5LyNHlbbAlQMtl1zKe/koVc7B0Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;6:TrYGHXLkey05OYfX1QqBIKVdphEDQ4Fb+JxKxIMGri2DW/GskhHb4NY5QY3aNXmEJdfUH3fN6OluP9eZDLPslJ6cod5fT6+lHd4A469zyR7xK9oNoUC7dOtiB06QCcLRElsShVXNVxBxgOSv2enSOO01OUcPbTS3mhaiAvcFuaAx/hlIVv1JV6esOa/FWyN1GLE/JokO0GN5ifbavEPVAujTNmDnNElKusc56OFZFYjzOZHucICwHCssX4u1/ltnivWISMlhWT/xrXPHEnCdavtv0qzbfDrxbZhLZcNc1/3l2fSi7gLbRadX2HlhOC4epFG6A6fZFFEDAeTs64EHM8pkyBdNcCWnftrzXLUn20r8R0VFHGw6M0NUIso6D/Wxo+dlKR1h0w7wWMiDZcsHXQ==;5:SLTDDehnObdWjYaGmXflax2DjA3msoup4yCpc3DTCg3jhRe/kGqrElsQInyE7Hd3zeoG/QF39qD9kKbce0SL3oIw9k86PzBU7TTV7X/E8h2HN6PpQUh+x2TktIrb20ZkGIGWXoevhwPeSpqrrhBBsw==;24:uXbZax9GfVgu9m7jqVgRZm+mmfR27yRzzrA9IxfO6z6urow+0jwzSiFKEp8vugzTvWwphganoshj/a7S+9lfefJkAerfucW6i3mIGdi9goY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;7:kIUkCbDhveMQDOoL/Trh08rhEHLqBe6fbYFeUkPqiyCKCYZEwvGQxPDut1Y9G1z19szFQfOcvmVM/1NlwaNtCugfj6i4gFkDt06fGBn9MB7O3t2h9nezAc9b2jGFg3c56WOMXNUYzUXgtyzW5APnJZZiYpc6iGo3xr4hGdDRbZd5wPRQWgES0b3DNmGugon4JRSsK8FrH3llwYtr98ynN+OrKLK25cae/tV8W4El+rck4ogMJOs8mew9YsY7l9LOlx/yhqLaDxSSE/dqGHfEyFv4mPlpZcZr0662/7eak7Ab9mGyTkWoQxmzFjabuckyKXgIB3W69buXZOmq3FlHeA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 08:37:40.4335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2559 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 35 i2c_mux_add_adapter already logs a message on failure. Signed-off-by: Peter Rosin --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c index 35e9acfe63d3..dff514e147da 100644 --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c @@ -576,17 +576,10 @@ int cx231xx_i2c_mux_create(struct cx231xx *dev) int cx231xx_i2c_mux_register(struct cx231xx *dev, int mux_no) { - int rc; - - rc = i2c_mux_add_adapter(dev->muxc, - 0, - mux_no /* chan_id */, - 0 /* class */); - if (rc) - dev_warn(dev->dev, - "i2c mux %d register FAILED\n", mux_no); - - return rc; + return i2c_mux_add_adapter(dev->muxc, + 0, + mux_no /* chan_id */, + 0 /* class */); } void cx231xx_i2c_mux_unregister(struct cx231xx *dev) -- 2.1.4