Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752199AbdDCJFb convert rfc822-to-8bit (ORCPT ); Mon, 3 Apr 2017 05:05:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37606 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbdDCJFa (ORCPT ); Mon, 3 Apr 2017 05:05:30 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E7C2EC04B317 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E7C2EC04B317 Message-ID: <1491210328.17505.34.camel@redhat.com> Subject: Re: [PATCH 1/2] drm: virtio: add virtio_gpu_translate_format From: Gerd Hoffmann To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, lvivier@redhat.com, open list , "open list:VIRTIO GPU DRIVER" Date: Mon, 03 Apr 2017 11:05:28 +0200 In-Reply-To: <20170403075110.besn4qv53nhwlrhu@phenom.ffwll.local> References: <20170403070845.10793-1-kraxel@redhat.com> <20170403070845.10793-2-kraxel@redhat.com> <20170403075110.besn4qv53nhwlrhu@phenom.ffwll.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 03 Apr 2017 09:05:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 531 Lines: 17 On Mo, 2017-04-03 at 09:51 +0200, Daniel Vetter wrote: > On Mon, Apr 03, 2017 at 09:08:44AM +0200, Gerd Hoffmann wrote: > > Factors out code, no functional change. > > > > Signed-off-by: Gerd Hoffmann > > Ugh on the big endian define, I guess we'll never managed to figure this > aspect of drm pixel formats out correctly - they're supposed to encode > endinaness. Oh, ok. (reading your patch replies out-of-order). Yep, in that case it maybe is a good idea to discuss fourcc semantics ... cheers, Gerd