Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbdDCK32 (ORCPT ); Mon, 3 Apr 2017 06:29:28 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:34361 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163AbdDCK3Z (ORCPT ); Mon, 3 Apr 2017 06:29:25 -0400 Date: Mon, 3 Apr 2017 11:29:21 +0100 From: Lee Jones To: Hugues Fruchet Cc: linux-kernel@vger.kernel.org, Benjamin Gaignard , Amelie DELAUNAY , Patrice Chotard Subject: Re: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600 Message-ID: <20170403102921.biv4g42c7fazizsf@dell> References: <1490947959-19597-1-git-send-email-hugues.fruchet@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1490947959-19597-1-git-send-email-hugues.fruchet@st.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 37 On Fri, 31 Mar 2017, Hugues Fruchet wrote: > GPIO bits clearing on pins assigned to STMPE1600 > had no effects due to missing "clear registers" > settings within stmpe1600_regs[]. > STMPE1600 does not have dedicated "clear registers", > but single "set/clear registers", hence stmpe1600_regs[] > "clear registers" (STMPE_IDX_GPCR_XXX) must be set to > same value as "set registers" (STMPE_IDX_GPSR_XXX), ie > STMPE1600_REG_GPSR_XXX. > > Signed-off-by: Hugues Fruchet > --- > drivers/mfd/stmpe.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c > index b0c7bcd..566caca 100644 > --- a/drivers/mfd/stmpe.c > +++ b/drivers/mfd/stmpe.c > @@ -568,6 +568,8 @@ static int stmpe811_get_altfunc(struct stmpe *stmpe, enum stmpe_block block) > [STMPE_IDX_GPMR_CSB] = STMPE1600_REG_GPMR_MSB, > [STMPE_IDX_GPSR_LSB] = STMPE1600_REG_GPSR_LSB, > [STMPE_IDX_GPSR_CSB] = STMPE1600_REG_GPSR_MSB, > + [STMPE_IDX_GPCR_LSB] = STMPE1600_REG_GPSR_LSB, > + [STMPE_IDX_GPCR_CSB] = STMPE1600_REG_GPSR_MSB, > [STMPE_IDX_GPDR_LSB] = STMPE1600_REG_GPDR_LSB, > [STMPE_IDX_GPDR_CSB] = STMPE1600_REG_GPDR_MSB, > [STMPE_IDX_IEGPIOR_LSB] = STMPE1600_REG_IEGPIOR_LSB, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog