Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbdDCLNK (ORCPT ); Mon, 3 Apr 2017 07:13:10 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:35595 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbdDCLNI (ORCPT ); Mon, 3 Apr 2017 07:13:08 -0400 Date: Mon, 3 Apr 2017 12:13:01 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland Subject: Re: [PATCH v3 1/7] mfd: Add Device Tree bindings document for retu/tahvo ASIC chips Message-ID: <20170403111301.52hm4wsplimviqso@dell> References: <20170401071854.23198-1-javier@osg.samsung.com> <20170401071854.23198-2-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170401071854.23198-2-javier@osg.samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1607 Lines: 52 On Sat, 01 Apr 2017, Javier Martinez Canillas wrote: > There are Device Tree source files defining a device node for the > retu/tahvo I2C chip, but there isn't a DT binding document for it. > > Signed-off-by: Javier Martinez Canillas > --- > > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/mfd/retu.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt > > diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentation/devicetree/bindings/mfd/retu.txt > new file mode 100644 > index 000000000000..2309e599a731 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/retu.txt > @@ -0,0 +1,19 @@ > +* Device tree bindings for Nokia Retu and Tahvo multi-function device > + > +Retu and Tahvo are a multi-function devices found on Nokia Internet > +Tablets (770, N800 and N810). More information please. What functions to they serve? > +Required properties: > +- compatible: "nokia,retu-mfd" or "nokia,tahvo-mfd" > +- reg: Specifies the I2C slave address of the ASIC chip > + > +Example: > + > +i2c0 { > + retu_mfd: retu@1 { Please avoid the term MFD at all times when using Device Tree. DT is meant to be OS agnostic and MFD is a Linuxisum. > + compatible = "nokia,retu-mfd"; > + interrupt-parent = <&gpio4>; > + interrupts = <12 IRQ_TYPE_EDGE_RISING>; > + reg = <0x1>; > + }; > +}; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog