Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752715AbdDCLRK (ORCPT ); Mon, 3 Apr 2017 07:17:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34724 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbdDCLRI (ORCPT ); Mon, 3 Apr 2017 07:17:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1B7A53F3C0 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=david@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1B7A53F3C0 Subject: Re: [PATCH 2/6] KVM: VMX: remove bogus check for invalid EPT violation To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1490867732-16743-1-git-send-email-pbonzini@redhat.com> <1490867732-16743-3-git-send-email-pbonzini@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <1e1fbaf4-8ef3-a049-0611-fe810ee1c501@redhat.com> Date: Mon, 3 Apr 2017 13:17:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1490867732-16743-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 03 Apr 2017 11:17:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1811 Lines: 52 On 30.03.2017 11:55, Paolo Bonzini wrote: > handle_ept_violation is checking for "guest-linear-address invalid" + > "not a paging-structure walk". However, _all_ EPT violations without > a valid guest linear address are paging structure walks, because those > EPT violations happen when loading the guest PDPTEs. > > Therefore, the check can never be true, and even if it were, KVM doesn't > care about the guest linear address; it only uses the guest *physical* > address VMCS field. So, remove the check altogether. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/vmx.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 0e61b9226bf2..1c372600a962 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -6208,23 +6208,9 @@ static int handle_ept_violation(struct kvm_vcpu *vcpu) > unsigned long exit_qualification; > gpa_t gpa; > u32 error_code; > - int gla_validity; > > exit_qualification = vmcs_readl(EXIT_QUALIFICATION); > > - gla_validity = (exit_qualification >> 7) & 0x3; > - if (gla_validity == 0x2) { > - printk(KERN_ERR "EPT: Handling EPT violation failed!\n"); > - printk(KERN_ERR "EPT: GPA: 0x%lx, GVA: 0x%lx\n", > - (long unsigned int)vmcs_read64(GUEST_PHYSICAL_ADDRESS), > - vmcs_readl(GUEST_LINEAR_ADDRESS)); > - printk(KERN_ERR "EPT: Exit qualification is 0x%lx\n", > - (long unsigned int)exit_qualification); > - vcpu->run->exit_reason = KVM_EXIT_UNKNOWN; > - vcpu->run->hw.hardware_exit_reason = EXIT_REASON_EPT_VIOLATION; > - return 0; > - } > - > /* > * EPT violation happened while executing iret from NMI, > * "blocked by NMI" bit has to be set before next VM entry. > Reviewed-by: David Hildenbrand -- Thanks, David