DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AE99976F6
Subject: Re: [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture
 agnostic
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <1490961203-7139-1-git-send-email-pbonzini@redhat.com>
 <1490961203-7139-2-git-send-email-pbonzini@redhat.com>
 <20170331134106.GC6019@potion>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lei.cao@stratus.com
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <77245545-1ed2-6a97-3bb6-8c6f2e3fdcc1@redhat.com>
Date: Mon, 3 Apr 2017 13:29:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170331134106.GC6019@potion>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 737
Lines: 26

On 31.03.2017 15:41, Radim Krčmář wrote:
> 2017-03-31 13:53+0200, Paolo Bonzini:
>> Remove code from architecture files that can be moved to virt/kvm, since there
>> is already common code for coalesced MMIO.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> @@ -2919,6 +2919,11 @@ static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
>> +#ifdef KVM_COALESCED_MMIO_PAGE_OFFSET
>> +	case KVM_CAP_COALESCED_MMIO:
>> +		return KVM_COALESCED_MMIO_PAGE_OFFSET;
>> +		break;
> 
> This 'break;' is pointless and would be best removed when applying,
> thanks.

With that,

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David